Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the <rank> form control, closes #104 #180

Merged
merged 2 commits into from
Jun 27, 2018
Merged

Conversation

MartijnR
Copy link
Contributor

No description provided.

@lognaturel
Copy link
Member

@MartijnR This looks great. If you don't mind, I'd like to wait until there is a concrete implementation before merging. I've gotten the feedback that it's confusing to have things in the spec that don't exist anywhere and since this is coming really soon, I think it's easiest to merge once the feature is in somewhere.

@MartijnR
Copy link
Contributor Author

MartijnR commented May 16, 2018

@MartijnR
Copy link
Contributor Author

MartijnR commented Jun 14, 2018

How's it going with the Collect widget? Enketo will have one (a rough one because of minimal funding) next week.

Interesting challenge is the 'empty' state of the widget. Still trying to figure that out UI-wise.

@lognaturel
Copy link
Member

Great! It's ready on the Collect side as well but probably won't go out for another couple weeks. Clearing the value currently re-establishes the original order -- I couldn't come up with another reasonable option. When you say 'empty' state, do you mean you'd like an enumerator to be able to indicate that they have skipped the question? For that I'd tend to say the form creator should account for that by doing something like asking whether the enumerator has a preferred order and adjusting the relevance of the rank question based on that response.

@MartijnR
Copy link
Contributor Author

MartijnR commented Jun 14, 2018

When you say 'empty' state, do you mean you'd like an enumerator to be able to indicate that they have skipped the question?

Yes, and in addition, the enumerator may also decide later to clear the value (the recorded ranked list). This would also make the "required" condition work normally.

So my approach is to visually show an empty state of the widget (which means the value is ""). It may say "Click to start" or something. This way it will have all the functionality that other widgets have (in Enketo).

In Enketo there will be no way to restore the original order, I think. Clicking reset will simply keep the order but clear the value and visually show the empty state.

@lognaturel
Copy link
Member

Hmm, we should probably coordinate on this. Do you have a rough sketch of the UI you have in mind?

@MartijnR
Copy link
Contributor Author

MartijnR commented Jun 14, 2018

Yes, like this:

No value in model (after reset, or after loading empty form):

screen shot 2018-06-14 at 11 46 52 am

Has value (and value updates automatically in model, when user changes order):

screen shot 2018-06-14 at 11 46 58 am

@MartijnR
Copy link
Contributor Author

The same 'empty state' requirements could also be met with a 'Confirm' button, but I liked it less.

@lognaturel lognaturel merged commit 24d3cd2 into gh-pages Jun 27, 2018
@lognaturel lognaturel deleted the feature/rank branch June 27, 2018 23:22
@lognaturel
Copy link
Member

We have implementations ready to ship and XLSForm support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants