Extra pages #59

noirbizarre · 2018-02-21T15:42:25Z

This PR adds the following pages:

usage
strategy
publishing
FAQ (and subsections)

It also adds the data.public.lu terms as a themed terms.html template.

Also added: related tests

petzlux · 2018-02-21T15:58:08Z

I get the following error:

udata_1          | Installing collected packages: gouvlu
udata_1          |   Running setup.py develop for gouvlu
udata_1          | Successfully installed gouvlu
mongodb_1        | 2018-02-21T16:14:01.979+0000 I NETWORK  [initandlisten] connection accepted from 172.24.0.5:41158 #1 (1 connection now open)
udata_1          | Traceback (most recent call last):
udata_1          |   File "/usr/local/bin/udata", line 11, in <module>
udata_1          |     sys.exit(console_script())
udata_1          |   File "/usr/local/lib/python2.7/dist-packages/udata/commands/__init__.py", line 93, in console_script
udata_1          |     run_manager()
udata_1          |   File "/usr/local/lib/python2.7/dist-packages/udata/commands/__init__.py", line 82, in run_manager
udata_1          |     app = standalone(app)
udata_1          |   File "/usr/local/lib/python2.7/dist-packages/udata/app.py", line 181, in standalone
udata_1          |     plugin = import_module(name)
udata_1          |   File "/usr/lib/python2.7/importlib/__init__.py", line 37, in import_module
udata_1          |     __import__(name)
udata_1          | ImportError: No module named udata_gouvlu
mongodb_1        | 2018-02-21T16:14:03.590+0000 I NETWORK  [conn1] end connection 172.24.0.5:41158 (0 connections now open)
gouvlu_udata_1 exited with code 1

noirbizarre · 2018-02-21T16:13:44Z

This requires udata 1.3.0.dev to run because of the udata.views entrypoint.

The 1.3 versions is breaking some cards design too but a PR is coming with fixes.

noirbizarre · 2018-02-21T16:53:43Z

Yes, you can with the development version of udata.
Udata developement version are published here: https://pypi.python.org/pypi/udata
Successful build use latest one

petzlux · 2018-02-23T08:42:27Z

I have problems with the design of the cards, which seems slightly broken ?

Left old from demoprod, right this PR

petzlux

I think the card design is broken, because these changes werent taken into account:

opendatateam/udata#1383

petzlux

Cant be merged at the moment, need to address these two issues

petzlux · 2018-02-23T10:00:00Z

gouvlu/views.py

+
+@blueprint.route('/strategy/')
+def strategy():
+    return theme.render('usage.html')


this should load the strategy.html

petzlux · 2018-02-23T10:01:04Z

requirements/install.pip

@@ -1,2 +1,2 @@
-udata>=1.2.6
+udata>=1.3.0.dev6747


Managed to fix the card design by specifying the build just before the card redesign PR was merged udata==1.3.0.dev6411

noirbizarre · 2018-02-23T11:06:57Z

The 1.3 versions is breaking some cards design too but a PR is coming with fixes.

I know, we are currently working on it. opendatateam/udata#1383 was the first pass, and opendatateam/udata#1460 is making some changes too. I already have fixed it, but I'm waiting for opendatateam/udata#1460 to be merged to submit the fix so it can be tested.

This current PR is only about the extra pages, there is no changes on cards which will break with or without.

petzlux · 2018-02-23T13:16:27Z

Okay, but can we fix to udata==1.3.0.dev6411 to be able to merge ?

noirbizarre · 2018-02-23T17:05:32Z

No I can't, this is really this required version to make this PR works. Tests won't pass with an earlier version and not everything is functionnal.
See #61 for the cards fixes (I try to keeps PR coherents). Once merged, I can rebase this branch if you want. (This PR doesn't touch or use cards, so reviewing the extra pages won't changes with #61 )

petzlux · 2018-02-26T08:08:56Z

Okay I understand. Lets get #61 merged then before.

petzlux · 2018-02-26T08:09:59Z

The FAQ System Integrator doesnt seem to work:

Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1997, in __call__
    return self.wsgi_app(environ, start_response)
  File "/usr/local/lib/python2.7/dist-packages/werkzeug/contrib/fixers.py", line 152, in __call__
    return self.app(environ, start_response)
  File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1985, in wsgi_app
    response = self.handle_exception(e)
  File "/usr/local/lib/python2.7/dist-packages/flask_restplus/api.py", line 557, in error_router
    return original_handler(e)
  File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1540, in handle_exception
    reraise(exc_type, exc_value, tb)
  File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1982, in wsgi_app
    response = self.full_dispatch_request()
  File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1614, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/usr/local/lib/python2.7/dist-packages/flask_restplus/api.py", line 557, in error_router
    return original_handler(e)
  File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1517, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1612, in full_dispatch_request
    rv = self.dispatch_request()
  File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1598, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/src/gouvlu/gouvlu/views.py", line 23, in faq
    url_pattern=FAQ_URL_PATTERN)
  File "/usr/local/lib/python2.7/dist-packages/udata/theme/__init__.py", line 132, in render
    return render_theme_template(get_theme(theme), template, **context)
  File "/usr/local/lib/python2.7/dist-packages/flask_themes2/__init__.py", line 141, in render_theme_template
    return render_template(template_name, **context)
  File "/usr/local/lib/python2.7/dist-packages/flask/templating.py", line 134, in render_template
    context, ctx.app)
  File "/usr/local/lib/python2.7/dist-packages/flask/templating.py", line 116, in _render
    rv = template.render(context)
  File "/usr/local/lib/python2.7/dist-packages/jinja2/environment.py", line 1008, in render
    return self.environment.handle_exception(exc_info, True)
  File "/usr/local/lib/python2.7/dist-packages/jinja2/environment.py", line 780, in handle_exception
    reraise(exc_type, exc_value, tb)
  File "/src/gouvlu/gouvlu/templates/faq/system-integrator.html", line 3, in top-level template code
    {% set meta = {
  File "/src/gouvlu/gouvlu/templates/faq/base.html", line 1, in top-level template code
    {% extends theme('layouts/1-column.html') %}
  File "/usr/local/lib/python2.7/dist-packages/udata/templates/layouts/1-column.html", line 4, in top-level template code
    {% set toolbar_class = toolbar_class|default('') %}
  File "/src/gouvlu/gouvlu/theme/templates/base.html", line 1, in top-level template code
    {% extends "base.html" %}
  File "/usr/local/lib/python2.7/dist-packages/udata/templates/base.html", line 1, in top-level template code
    {% extends theme('raw.html') %}
  File "/src/gouvlu/gouvlu/theme/templates/raw.html", line 2, in top-level template code
    {% extends "raw.html" %}
  File "/usr/local/lib/python2.7/dist-packages/udata/templates/raw.html", line 29, in top-level template code
    {% block body %}{% endblock %}
  File "/src/gouvlu/gouvlu/theme/templates/base.html", line 9, in block "body"
    {{ super() }}
  File "/usr/local/lib/python2.7/dist-packages/udata/templates/base.html", line 19, in block "body"
    {% block content %}{% endblock %}
  File "/usr/local/lib/python2.7/dist-packages/udata/templates/layouts/1-column.html", line 14, in block "content"
    {% block main_content %}{% endblock %}
  File "/src/gouvlu/gouvlu/templates/faq/base.html", line 9, in block "main_content"
    {% block faq_content %}{% endblock %}
  File "/src/gouvlu/gouvlu/templates/faq/system-integrator.html", line 43, in block "faq_content"
    <img src="{{ url_for('gouvfr.static', filename='faq/integration/exemple-integration-blog-etalab.png') }}" alt="Exemple d’intégration sur le blog d’Etalab">
  File "/usr/local/lib/python2.7/dist-packages/flask/helpers.py", line 333, in url_for
    return appctx.app.handle_url_build_error(error, endpoint, values)
  File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1805, in handle_url_build_error
    reraise(exc_type, exc_value, tb)
  File "/usr/local/lib/python2.7/dist-packages/flask/helpers.py", line 323, in url_for
    force_external=external)
  File "/usr/local/lib/python2.7/dist-packages/werkzeug/routing.py", line 1776, in build
    raise BuildError(endpoint, values, method, self)
BuildError: Could not build url for endpoint 'gouvfr.static' with values ['filename']. Did you mean u'gouvlu.static' instead?

noirbizarre · 2018-02-26T09:41:13Z

Fixed
BTW, I think we face the same problem than before: udata-gouvlu repository is not up to date and so are the extracted pages

noirbizarre added this to the 1.0.0 milestone Feb 21, 2018

noirbizarre self-assigned this Feb 21, 2018

noirbizarre added this to To Do in Road to udata 1.X via automation Feb 21, 2018

noirbizarre requested a review from petzlux February 21, 2018 15:42

noirbizarre added the in progress label Feb 21, 2018

noirbizarre moved this from To Do to In progress in Road to udata 1.X Feb 21, 2018

noirbizarre force-pushed the extra-pages branch from f3c5049 to 8f0b257 Compare February 21, 2018 15:53

noirbizarre force-pushed the extra-pages branch 2 times, most recently from 757888d to c971e25 Compare February 21, 2018 16:12

noirbizarre force-pushed the extra-pages branch from 1fac1ed to be75ebc Compare February 21, 2018 16:50

petzlux suggested changes Feb 23, 2018

View reviewed changes

noirbizarre added 4 commits February 26, 2018 10:20

Adds FAQ, usage, strategy... pages and add more tests

b2ca963

Update translations

7c8a9ae

Ensure docker config does not interacte with test

36afb5f

Flush CircleCI cache

dcbb3af

noirbizarre force-pushed the extra-pages branch from 62f1f98 to 36f0ce3 Compare February 26, 2018 09:27

Fix

e66a3ce

noirbizarre force-pushed the extra-pages branch from 36f0ce3 to e66a3ce Compare February 26, 2018 09:30

Added missing images

321bcf5

petzlux merged commit b0a0aa1 into opendatalu:master Feb 26, 2018

Road to udata 1.X automation moved this from In progress to Done Feb 26, 2018

noirbizarre removed the in progress label Feb 26, 2018

noirbizarre deleted the extra-pages branch February 26, 2018 10:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Extra pages #59

Extra pages #59

noirbizarre commented Feb 21, 2018

petzlux commented Feb 21, 2018

noirbizarre commented Feb 21, 2018

noirbizarre commented Feb 21, 2018

petzlux commented Feb 23, 2018

petzlux left a comment

petzlux left a comment

petzlux Feb 23, 2018

petzlux Feb 23, 2018

noirbizarre commented Feb 23, 2018

petzlux commented Feb 23, 2018

noirbizarre commented Feb 23, 2018 •

edited

petzlux commented Feb 26, 2018

petzlux commented Feb 26, 2018

noirbizarre commented Feb 26, 2018

		@@ -1,2 +1,2 @@
		udata>=1.2.6
		udata>=1.3.0.dev6747

Extra pages #59

Extra pages #59

Conversation

noirbizarre commented Feb 21, 2018

petzlux commented Feb 21, 2018

noirbizarre commented Feb 21, 2018

noirbizarre commented Feb 21, 2018

petzlux commented Feb 23, 2018

petzlux left a comment

Choose a reason for hiding this comment

petzlux left a comment

Choose a reason for hiding this comment

petzlux Feb 23, 2018

Choose a reason for hiding this comment

petzlux Feb 23, 2018

Choose a reason for hiding this comment

noirbizarre commented Feb 23, 2018

petzlux commented Feb 23, 2018

noirbizarre commented Feb 23, 2018 • edited

petzlux commented Feb 26, 2018

petzlux commented Feb 26, 2018

noirbizarre commented Feb 26, 2018

noirbizarre commented Feb 23, 2018 •

edited