Make cards consistent again #1383
Conversation
|
I think you need to rebase on the current master. The changelog seems to indicate that you are working a an old version of the master |
Introduce the concept of concept colors. Each card type has its own distinct color. It will be leveraged at the resource level in a further pull request
Likewise for the Reuses
Also, signpost Community sections
It has too many side effects on the rest of the app otherwise.
|
@noirbizarre I have conflicts with your two last merges. I have integrated the second one but overrided part of the first one. |
|
There are problems with some slides on the carousel with the default theme:
|
|
I wonder if we should have some different, more neutral colors for cards footer in the default theme. BTW, we agreed some time ago that the cards footer colors should be configurable, is this the case? |
|
Former presentation is fine to be, but this is currently broken. Incoherent on default theme too:
|
|
There is a slight problem with tooltips on texts that overflow a lot (this is the tooltip of the left card):
http://demo.data.gouv.fr/fr/datasets/panorama-des-grands-projets-si-de-letat-1/ |
|
Slight problem between breakpoints on the admin (~1200px wide here):
https://demo.data.gouv.fr/fr/admin/editorial/ Proposed solution: only one item per row on both columns for all breakpoints. |
|
Problem with dataset card on reuse page in the admin:
https://demo.data.gouv.fr/fr/admin/reuse/596f5fd5c751df02a36e4726/ |
|
The two previous bugs have been fixed. Can someone get a detailed look at the very last commit? I have change a stuff in the api and need an impact assesment |
|
|
|
@taniki regarding your question, it might be better to add the fields you need to |
|
Reuse cards from companies display |
|
Problems on user and org cards when creating a dataset:
|
|
Problem on topic admin view: https://demo.data.gouv.fr/fr/admin/topic/53552f47c751df3ceca6f823
|
|
Misaligned close icon on topic dataset edition (clearly not critical):
|
|
Still a small glitch on user card (bottom right corner) when creating a dataset (can be fixed later):
|
|
|
Based upon Improve Cards consistency but with features sorted out in various PR.
This one is only about a global overlook of look and feel of cards.
extracts