Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit dataset search reuse facet context (only known reuses) #1219

Merged
merged 1 commit into from
Oct 18, 2017
Merged

Explicit dataset search reuse facet context (only known reuses) #1219

merged 1 commit into from
Oct 18, 2017

Conversation

noirbizarre
Copy link
Contributor

Be explicit in the reuse facet header that these are only known reuses.

Fix datagouv/data.gouv.fr#26

@noirbizarre noirbizarre added this to the 1.2.0 milestone Oct 18, 2017
@noirbizarre noirbizarre requested a review from a team October 18, 2017 08:17
@noirbizarre noirbizarre merged commit b658396 into opendatateam:master Oct 18, 2017
@noirbizarre noirbizarre deleted the dgfr-26-reuses-facets-context branch October 18, 2017 09:04
@schignard
Copy link

J'ai pas bien compris la dernière action. Qu'est-ce qui s'est finalement décidé ?

@noirbizarre
Copy link
Contributor Author

@schignard French response in datagouv/data.gouv.fr#26

@@ -15,6 +15,6 @@
{{ s.model_terms_facet(datasets, 'geozone', _('Spatial coverage'), ficon('fa-map-marker'), url=url) }}
{{ s.terms_facet(datasets, 'granularity', _('Territorial granularity'), ficon('fa-bullseye'), url=url) }}
{{ s.terms_facet(datasets, 'format', _('Formats'), ficon('fa-file'), url=url) }}
{{ s.range_facet(datasets, 'reuses', _('Reuses'), ficon('fa-retweet'), url=url) }}
{{ s.range_facet(datasets, 'reuses', _('Known reuses'), ficon('fa-retweet'), url=url) }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants