Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wip] Put missing spinners on various parts #1399

Closed
wants to merge 1 commit into from
Closed

[wip] Put missing spinners on various parts #1399

wants to merge 1 commit into from

Conversation

taniki
Copy link
Contributor

@taniki taniki commented Jan 25, 2018

No description provided.

@taniki
Copy link
Contributor Author

taniki commented Jan 25, 2018

udata/js/components/datatable/widget.vue

Line 16 in 05e723b

:loading="loading !== undefined ? loading : p.loading"

Wondering if it is not more of a bug than missing stuffs. The line above should do the job right?

@taniki
Copy link
Contributor Author

taniki commented Jan 25, 2018

Yep that's it. the condition is always true because the prop defaults false

@taniki taniki mentioned this pull request Jan 26, 2018
Merged
@taniki taniki closed this Jan 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@taniki