Chunked upload support #1468
Merged
Chunked upload support #1468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abulte
suggested changes
Mar 2, 2018
udata/core/dataset/api_fields.py
Outdated
| @@ -187,4 +187,4 @@ | |||
| description='The web page URL for this dataset', readonly=True), | |||
| 'score': fields.Float( | |||
| description='The internal match score', required=True), | |||
| }) | |||
| }) | |||
udata/core/storages/api.py
Outdated
|
|
||
| def on_upload_status(status): | ||
| '''Not an error, just raised when chunk is processed''' | ||
| print('in handler', status.ok, status.error) |
udata/core/storages/api.py
Outdated
| def handle_upload(storage, prefix=None): | ||
| args = upload_parser.parse_args() | ||
| is_chunk = args['totalparts'] > 1 | ||
| file = args['file'] |
|
|
||
|
|
||
| def extension(filename): | ||
| '''Properly extract the extension from filename''' |
There was a problem hiding this comment.
Cool, we had problems with that 👍
There was a problem hiding this comment.
I think we'll still have problems with that kind of filenames though Capture d'écran 2018-02-13 16.03.07.png. Maybe check against a list of known extensions and if found do not try to parse a compounded one? But it could get complicated.
There was a problem hiding this comment.
Yes, I didn't changed anything, I just grouped an existing function.
I think I can improve the behavior, but in another PR
udata/tests/api/test_datasets_api.py
Outdated
| 'partbyteoffset': 0, | ||
| 'totalfilesize': parts, | ||
| 'totalparts': parts, | ||
| 'chunksize': 1 |
There was a problem hiding this comment.
Add a comma here if we you add one on the last item of the dict below ;-)
udata/tests/test_storages.py
Outdated
| 'partbyteoffset': 0, | ||
| 'totalfilesize': parts, | ||
| 'totalparts': parts, | ||
| 'chunksize': 1 |
|
Changes done |
abulte
approved these changes
Mar 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds chunked upload support, ie. uploads are no more limited by max_body_size and udata is able to handle big files upload.
This is is a first pass only adding chunked and concurrent upload support.
What can be improved in other PRs: