Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload errors handling #1842

Merged
merged 6 commits into from
Aug 23, 2018
Merged

Upload errors handling #1842

merged 6 commits into from
Aug 23, 2018

Conversation

noirbizarre
Copy link
Contributor

This PR improves upload errors handling by:

  • deduplicating notifications (only one by file instead of one for every chunk)
  • localizing the default xhr error
  • handling multiline notification details formating
  • displaying the Sentry ID if present

@noirbizarre noirbizarre added this to the 1.6.0 milestone Aug 22, 2018
@noirbizarre noirbizarre self-assigned this Aug 22, 2018
@noirbizarre noirbizarre requested a review from a team August 22, 2018 14:00
@noirbizarre noirbizarre merged commit 9a2fcaf into opendatateam:master Aug 23, 2018
@noirbizarre noirbizarre deleted the upload-errors-handling branch August 23, 2018 16:02
@noirbizarre noirbizarre mentioned this pull request Aug 24, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taniki taniki taniki approved these changes

Assignees

@noirbizarre noirbizarre

Labels
admin bug enhancement user experience
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@noirbizarre @taniki