Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload errors handling #1842

Merged
merged 6 commits into from Aug 23, 2018

Conversation

Projects
None yet
2 participants
@noirbizarre
Copy link
Member

commented Aug 22, 2018

This PR improves upload errors handling by:

  • deduplicating notifications (only one by file instead of one for every chunk)
  • localizing the default xhr error
  • handling multiline notification details formating
  • displaying the Sentry ID if present

@noirbizarre noirbizarre added this to the 1.6.0 milestone Aug 22, 2018

@noirbizarre noirbizarre self-assigned this Aug 22, 2018

@noirbizarre noirbizarre requested a review from opendatateam/etalab Aug 22, 2018

@noirbizarre noirbizarre force-pushed the noirbizarre:upload-errors-handling branch from 448efad to bad7cda Aug 22, 2018

@taniki

taniki approved these changes Aug 23, 2018

@noirbizarre noirbizarre merged commit 9a2fcaf into opendatateam:master Aug 23, 2018

3 checks passed

ci/circleci: assets Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: python Your tests passed on CircleCI!
Details

@noirbizarre noirbizarre deleted the noirbizarre:upload-errors-handling branch Aug 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.