Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix non unique ids #2374

Merged
merged 10 commits into from Dec 27, 2019
Merged

Fix non unique ids #2374

merged 10 commits into from Dec 27, 2019

Conversation

quaxsze
Copy link
Contributor

@quaxsze quaxsze commented Dec 27, 2019 •
edited

fix #2373

@quaxsze quaxsze changed the title Issue2373 Fix non unique ids Dec 27, 2019
@quaxsze quaxsze requested a review from abulte December 27, 2019 11:08
abulte
abulte suggested changes Dec 27, 2019
View reviewed changes
js/components/discussions/thread-form.vue Outdated Show resolved Hide resolved
@quaxsze quaxsze requested a review from abulte December 27, 2019 11:16
@quaxsze quaxsze requested a review from abulte December 27, 2019 11:49
abulte
abulte approved these changes Dec 27, 2019
View reviewed changes
Copy link
Contributor

@abulte abulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHANGELOG.md Outdated Show resolved Hide resolved
@quaxsze @abulte
Update CHANGELOG.md
96a0ecb 
Co-Authored-By: Alexandre Bulté <alexandre@bulte.net>
@quaxsze quaxsze merged commit 8c89a3c into opendatateam:master Dec 27, 2019
@quaxsze quaxsze deleted the issue2373 branch December 27, 2019 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abulte abulte abulte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Discussions: non unique ids in DOM
2 participants
@quaxsze @abulte