Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix non unique ids #2374

Merged
merged 10 commits into from
Dec 27, 2019
Merged

Fix non unique ids #2374

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b70d092
fixed role modal default
Dec 18, 2019
c729d5b
Merge branch 'master' of https://github.com/opendatateam/udata
Dec 26, 2019
a3054c6
Merge branch 'master' of https://github.com/opendatateam/udata
Dec 26, 2019
811163d
Merge branch 'master' of https://github.com/opendatateam/udata
Dec 27, 2019
62eac7d
fixed non unique ids
Dec 27, 2019
f9d452d
changelog
Dec 27, 2019
f5e7134
indent
Dec 27, 2019
e30e3e4
used props instead
Dec 27, 2019
8e86fcf
fstring
Dec 27, 2019
96a0ecb
Update CHANGELOG.md
quaxsze Dec 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
- Fix admin messages and fix user roles selector default value [#2365](https://github.com/opendatateam/udata/pull/2365)
- Fix new harvester's form tooltip showup [#2371](https://github.com/opendatateam/udata/pull/2371)
- Fix responsive design of search results [#2372](https://github.com/opendatateam/udata/pull/2372)
- Fix non-unique ids in datasets's comments [#2374](https://github.com/opendatateam/udata/pull/2374)
quaxsze marked this conversation as resolved.
Show resolved Hide resolved

## 1.6.18 (2019-12-13)

Expand Down
9 changes: 5 additions & 4 deletions js/components/discussions/thread-form.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<template>
<form role="form" class="clearfix animated" @submit.prevent="submit">
<div class="form-group">
<label for="comment-new-message">{{ _('Comment') }}</label>
<textarea v-el:textarea id="comment-new-message" v-model="comment" class="form-control" rows="3" required></textarea>
<label :for="id">{{ _('Comment') }}</label>
<textarea v-el:textarea :id="id" v-model="comment" class="form-control" rows="3" required></textarea>
</div>
<button type="submit" :disabled="this.sending || !this.comment" class="btn btn-primary btn-block pull-right submit-new-message">
{{ _('Submit your comment') }}
Expand All @@ -22,10 +22,11 @@ export default {
// Flags to `true` when the form is in sending process. This prevents
// duplicate POSTing.
sending: false,
comment: ''
comment: '',
id: `new-comment-${this.discussionId}`
}
},
methods: {
methods: {
/**
* Prefill the form and focus the comment area
*/
Expand Down