Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add contact points for Orgs and Users #2914

Merged
merged 48 commits into from Dec 14, 2023
Merged

Add contact points for Orgs and Users #2914

merged 48 commits into from Dec 14, 2023

Conversation

quaxsze
Copy link
Contributor

@quaxsze quaxsze commented Oct 19, 2023 •
edited

@quaxsze quaxsze changed the title Add contact points for Orgs and Users WIP: Add contact points for Orgs and Users Oct 19, 2023
@quaxsze quaxsze changed the title WIP: Add contact points for Orgs and Users Add contact points for Orgs and Users Oct 24, 2023
@quaxsze quaxsze requested a review from maudetes October 24, 2023 18:42
maudetes
maudetes reviewed Nov 7, 2023
View reviewed changes
Copy link
Contributor

@maudetes maudetes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution!
I haven't gotten my head around this modeling. I did not find the routes intuitive to manipulate contact points. Maybe using a db.Owned pattern would make it easier (and more coherent with existing patterns in udata). It's an open question, would be curious about your opinion.

udata/core/contact_points/models.py Outdated Show resolved Hide resolved
udata/core/organization/tasks.py Outdated Show resolved Hide resolved
udata/core/organization/tasks.py Show resolved Hide resolved
udata/core/contact_points/api.py Outdated Show resolved Hide resolved
udata/core/contact_points/api.py Outdated Show resolved Hide resolved
udata/core/contact_points/api.py Outdated Show resolved Hide resolved
udata/core/dataset/api.py Outdated Show resolved Hide resolved
quaxsze and others added 2 commits November 7, 2023 19:44
maudetes
maudetes reviewed Nov 8, 2023
View reviewed changes
udata/core/dataset/api.py Outdated Show resolved Hide resolved
udata/core/dataset/models.py Outdated Show resolved Hide resolved
@quaxsze quaxsze requested a review from maudetes November 9, 2023 13:00
maudetes
maudetes reviewed Nov 27, 2023
View reviewed changes
Copy link
Contributor

@maudetes maudetes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have only minor comments.
As a more general note, I'm thinking we should use a new custom fields.ContactField in forms instead of adding new routes to attach or detach contact points to datasets. What do you think?

udata/core/dataset/rdf.py Outdated Show resolved Hide resolved
udata/core/dataset/api.py Outdated Show resolved Hide resolved
udata/core/contact_point/api_fields.py Outdated Show resolved Hide resolved
udata/core/dataset/rdf.py Outdated Show resolved Hide resolved
udata/core/user/api.py Outdated Show resolved Hide resolved
@quaxsze @maudetes
Update udata/core/dataset/rdf.py
3754411 
Co-authored-by: maudetes <maudet.estelle@gmail.com>
maudetes
maudetes reviewed Nov 30, 2023
View reviewed changes
udata/core/dataset/rdf.py Outdated Show resolved Hide resolved
@quaxsze quaxsze requested a review from maudetes December 5, 2023 12:33
@quaxsze quaxsze requested a review from abulte December 13, 2023 13:17
maudetes
maudetes approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@maudetes maudetes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find the API nice now! 👏 Congrats!

udata/tests/api/test_datasets_api.py Show resolved Hide resolved
udata/core/contact_point/api.py Show resolved Hide resolved
udata/core/contact_point/api.py Outdated Show resolved Hide resolved
@quaxsze @maudetes
Update udata/core/dataset/models.py
8cd5994 
Co-authored-by: maudetes <maudet.estelle@gmail.com>
@quaxsze quaxsze merged commit 1105541 into master Dec 14, 2023
1 check passed
@quaxsze quaxsze deleted the ContactPoint branch December 14, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maudetes maudetes maudetes approved these changes

@abulte abulte Awaiting requested review from abulte

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

POC d'une métadonnée de points de contact au niveau d'une orga
3 participants
@quaxsze @abulte @maudetes