-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add contact points for Orgs and Users #2914
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this contribution!
I haven't gotten my head around this modeling. I did not find the routes intuitive to manipulate contact points. Maybe using a db.Owned
pattern would make it easier (and more coherent with existing patterns in udata). It's an open question, would be curious about your opinion.
Co-authored-by: maudetes <maudet.estelle@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have only minor comments.
As a more general note, I'm thinking we should use a new custom fields.ContactField
in forms instead of adding new routes to attach or detach contact points to datasets. What do you think?
Co-authored-by: maudetes <maudet.estelle@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find the API nice now! 👏 Congrats!
Co-authored-by: maudetes <maudet.estelle@gmail.com>
fix datagouv/data.gouv.fr#1182