Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JS locales handling by reverting to the old behavior #786

Merged
merged 1 commit into from Feb 21, 2017

Conversation

Projects
None yet
2 participants
@noirbizarre
Copy link
Member

noirbizarre commented Feb 20, 2017

Right now, i18n in JavaScript doesn't works asynchronously.
This PR revert to the previous behavior (locales packaged into common.js)

@noirbizarre noirbizarre added the bug label Feb 20, 2017

@noirbizarre noirbizarre added this to the 1.0.3 milestone Feb 20, 2017

@noirbizarre noirbizarre requested a review from davidbgk Feb 20, 2017

@noirbizarre noirbizarre force-pushed the noirbizarre:revert-legacy-i18n-js-loading branch from 170ac5c to 31fea64 Feb 20, 2017

@noirbizarre noirbizarre merged commit e6b87a7 into opendatateam:master Feb 21, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@noirbizarre noirbizarre deleted the noirbizarre:revert-legacy-i18n-js-loading branch Feb 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.