Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DB tuning on GenericReferenceField #801

Merged
merged 5 commits into from
Feb 27, 2017
Merged

DB tuning on GenericReferenceField #801

merged 5 commits into from
Feb 27, 2017

Conversation

noirbizarre
Copy link
Contributor

This PR apply some little tuning on disucssions and issues retrieval:

  • optimize the DB query when filtering on a single ID
  • ensure indexes and default order match the one provided as default from the API
  • manualy create the indexes that monoengine can't express (subject.id)

@noirbizarre noirbizarre added this to the 1.0.4 milestone Feb 23, 2017
@davidbgk
Copy link
Member

Were you able to measure the optimization?

@noirbizarre
Copy link
Contributor Author

Yes, ~200ms on a 950ms initial time

@noirbizarre noirbizarre merged commit a3ec23a into opendatateam:master Feb 27, 2017
@noirbizarre noirbizarre deleted the db-tuning branch February 27, 2017 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidbgk davidbgk davidbgk approved these changes

@vinyll vinyll Awaiting requested review from vinyll

@jdesboeufs jdesboeufs Awaiting requested review from jdesboeufs

@teleboas teleboas Awaiting requested review from teleboas

Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
1.0.4
Development

Successfully merging this pull request may close these issues.
2 participants
@noirbizarre @davidbgk