FW: Remove the ability to run without shared memory #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fenrus75
approved these changes
Jun 28, 2023
This was a debugging option that I created back in February 2021 to help me simulate runs with secure enclaves, where each process gets its own memory encryption and thus can't share memory with other processes. It was later used for the early Windows port, before we discovered how to have the child process inherit file descriptors from the parent (you have to use _spawnl(), not directly CreateProcessW()), but isn't needed any more there. Given the upcoming changes to support multiple child processes, this would be a complexity I could live without, so I'm removing. If the need arises, we can bring it back later, adapting as necessary. Signed-off-by: Thiago Macieira <thiago.macieira@intel.com>
See previous commit for rationale. [ChangeLog][Framework] Removed the ability to run without shared memory between the multiple tool processes. This ability existed to support process isolation in some secure enclave environments; it is now necessary to configure such environments to keep all the processes in the same enclave so they can share memory. Signed-off-by: Thiago Macieira <thiago.macieira@intel.com>
This simplifies the code considerably. Signed-off-by: Thiago Macieira <thiago.macieira@intel.com>
thiagomacieira
force-pushed
the
remove-no-shared-memory
branch
from
3a0700b
to
8437c48
Compare
fenrus75
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added this back in February 2021 to support running with secure enclaves, where each process gets its own memory encryption and thus can't share memory with other processes. It was later used for the early Windows port, before we discovered how to have the child process inherit file descriptors from the parent (you have to use
_spawnv(), not directlyCreateProcessW()), but isn't needed any more there.Given the upcoming changes to support multiple child processes, this would be a complexity I could live without, so I'm removing. If the need arises, we can bring it back later, adapting as necessary.
[ChangeLog][Framework] Removed the ability to run without shared memory
between the multiple tool processes. This ability existed to support
process isolation in some secure enclave environments; it is now
necessary to configure such environments to keep all the processes in
the same enclave so they can share memory.