Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FW: Remove the ability to run without shared memory #272

Merged
merged 3 commits into from
Jun 28, 2023
Merged

FW: Remove the ability to run without shared memory #272

merged 3 commits into from
Jun 28, 2023

Commits on Jun 28, 2023

  1. FW: remove the --no-shared-memory option 

    This was a debugging option that I created back in February 2021 to help
me simulate runs with secure enclaves, where each process gets its own
memory encryption and thus can't share memory with other processes. It
was later used for the early Windows port, before we discovered how to
have the child process inherit file descriptors from the parent (you
have to use _spawnl(), not directly CreateProcessW()), but isn't needed
any more there.

Given the upcoming changes to support multiple child processes, this
would be a complexity I could live without, so I'm removing. If the need
arises, we can bring it back later, adapting as necessary.

Signed-off-by: Thiago Macieira <thiago.macieira@intel.com>
    @thiagomacieira
    thiagomacieira committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    58f96a4 View commit details
    Browse the repository at this point in the history

  2. FW: remove the SharedMemorySynchronization class 

    See previous commit for rationale.

[ChangeLog][Framework] Removed the ability to run without shared memory
between the multiple tool processes. This ability existed to support
process isolation in some secure enclave environments; it is now
necessary to configure such environments to keep all the processes in
the same enclave so they can share memory.

Signed-off-by: Thiago Macieira <thiago.macieira@intel.com>
    @thiagomacieira
    thiagomacieira committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    5f31844 View commit details
    Browse the repository at this point in the history

  3. FW: remove init_shmem()'s fallback from failing to share memory 

    This simplifies the code considerably.

Signed-off-by: Thiago Macieira <thiago.macieira@intel.com>
    @thiagomacieira
    thiagomacieira committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    8437c48 View commit details
    Browse the repository at this point in the history