Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openshift pipeline build status steps don't get updates from jenkins piepline #86

Closed
clemensutschig opened this issue Mar 6, 2019 · 7 comments · Fixed by #117
Closed
Assignees
Labels
bug Something isn't working

Comments

@clemensutschig
Copy link
Member

clemensutschig commented Mar 6, 2019

Logs from jenkins master:

Terminated Kubernetes instance for agent tost-cd/jenkins-slave-vm5x7-65pk8
  | Disconnected computer jenkins-slave-vm5x7-65pk8
  | Mar 06, 2019 7:25:59 AM org.csanchez.jenkins.plugins.kubernetes.KubernetesSlave deleteSlavePod
  | INFO: Terminated Kubernetes instance for agent tost-cd/jenkins-slave-vm5x7-65pk8
  | Mar 06, 2019 7:25:59 AM org.csanchez.jenkins.plugins.kubernetes.KubernetesSlave _terminate
  | INFO: Disconnected computer jenkins-slave-vm5x7-65pk8
  | Mar 06, 2019 7:25:59 AM org.jenkinsci.plugins.workflow.job.WorkflowRun finish
  | INFO: tost-cd/tost-cd-be-docker-plain-test-master #10 completed: SUCCESS
  | Mar 06, 2019 7:25:59 AM hudson.model.listeners.RunListener report
  | WARNING: RunListener failed
| java.lang.NullPointerException
  | at io.fabric8.jenkins.openshiftsync.BuildSyncRunListener.upsertBuild(BuildSyncRunListener.java:336)
  | at io.fabric8.jenkins.openshiftsync.BuildSyncRunListener.pollRun(BuildSyncRunListener.java:226)
  | at io.fabric8.jenkins.openshiftsync.BuildSyncRunListener.onFinalized(BuildSyncRunListener.java:193)
  | at hudson.model.listeners.RunListener.fireFinalized(RunListener.java:257)
  | at hudson.model.Run.onEndBuilding(Run.java:1998)
  | at org.jenkinsci.plugins.workflow.job.WorkflowRun.finish(WorkflowRun.java:611)
  | at org.jenkinsci.plugins.workflow.job.WorkflowRun.access$900(WorkflowRun.java:132)
  | at org.jenkinsci.plugins.workflow.job.WorkflowRun$GraphL.onNewHead(WorkflowRun.java:993)
  | at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution.notifyListeners(CpsFlowExecution.java:1440)
  | at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup$3.run(CpsThreadGroup.java:417)
  | at org.jenkinsci.plugins.workflow.cps.CpsVmExecutorService$1.run(CpsVmExecutorService.java:35)
  | at hudson.remoting.SingleLaneExecutorService$1.run(SingleLaneExecutorService.java:131)
  | at jenkins.util.ContextResettingExecutorService$1.run(ContextResettingExecutorService.java:28)
  | at jenkins.security.ImpersonatingExecutorService$1.run(ImpersonatingExecutorService.java:59)
  | at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
  | at java.util.concurrent.FutureTask.run(FutureTask.java:266)
  | at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
  | at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
  | at java.lang.Thread.run(Thread.java:748)

see below:
image

https://github.com/openshift/jenkins-sync-plugin/blob/master/src/main/java/io/fabric8/jenkins/openshiftsync/BuildSyncRunListener.java#L336
nodes == null :(

@clemensutschig
Copy link
Member Author

openshift-sync-jar-fix.zip

extract and rsync replace openshift-sync.jar in /var/lib/jenkins/plugins/openshift-sync/WEB-INF/lib

@clemensutschig
Copy link
Member Author

Fixed in openshift Master;-) waiting for release information- where this will show up.

@michaelsauter
Copy link
Member

michaelsauter commented Mar 7, 2019

Awesome 👍

FYI @adyachok I think this is the reason for what you showed me recently

@clemensutschig
Copy link
Member Author

@michaelsauter - so in chatting with Gabe - the fix goes into OCP 4.0x :( ....
I suggest we package it with jenkins master... thoughts?

@michaelsauter
Copy link
Member

@clemensutschig What?! So they broke the sync in 3.11 and are going to leave this as it is? That is crazy.

I personally don't feel that ODS should fix what is broken in OpenShift ... if you feel strongly about it, we can package it with Jenkins, otherwise I would leave as is.

@maierl
Copy link

maierl commented May 27, 2019

Thanks for taking care about this!

@michaelsauter
Copy link
Member

As we have done some other "bugfixes" in the Jenkins master image, we decided to pull this into 1.1 too - see referenced PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants