Update Containers Probes in Jenkins #1195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsauter
previously approved these changes
Jan 23, 2023
| periodSeconds: 10 | ||
| successThreshold: 1 | ||
| timeoutSeconds: 3 | ||
| failureThreshold: 30 |
There was a problem hiding this comment.
Maybe this failureThreshold and the one of the livenessProbe could be reduced now that there is a separate startupProbe?
There was a problem hiding this comment.
I have made a quick test and we can reduce it safelly to 15 for both probes, but i would maintain the one for the StartupProbe
reduce failureThreshold for readiness and liveness Probes
michaelsauter
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #1191
This is needed as we have seen in our biggest cluster issues with Jenkins and its probes due to the amount of the instances
@metmajer @michaelsauter