Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify service requirements for certain tools #693

Closed
wants to merge 2 commits into from
Closed

Specify service requirements for certain tools #693

wants to merge 2 commits into from

Conversation

sino92
Copy link
Contributor

@sino92 sino92 commented Jul 6, 2020

@sino92 sino92 requested a review from michaelsauter July 6, 2020 15:13
michaelsauter
michaelsauter requested changes Jul 7, 2020
View reviewed changes
configuration-sample/ods-core.env.sample Outdated Show resolved Hide resolved
configuration-sample/ods-core.env.sample Outdated Show resolved Hide resolved
docs/modules/administration/pages/installation.adoc Outdated Show resolved Hide resolved
@michaelsauter
Copy link
Member

@sino92 Now we have merge conflicts :( To make things easier, I just went ahead and made some adjustments directly, see cc37340.

The only thing that you also have in this PR is the comment about checking the sample file before starting the config. If you feel that is needed, please update this PR accordingly. Personally, I don't feel it is that necessary as, when you run prepare-config, you are creating an ods-core.env file with all the comments from the sample file. So when people fill out that file, they see the comments anyway ...

What do you think? Do you want to close or update the PR?

@sino92
Copy link
Contributor Author

sino92 commented Jul 10, 2020

@michaelsauter I really liked the changes in this commit cc37340. Looks much better with the tag specified.
I hadn't caught prepare-config before, yes that seems like enough for me tbh. We can close this PR and the issue.

@sino92 sino92 closed this Jul 10, 2020
@sino92 sino92 deleted the doc/service-versions-ods-supports branch July 10, 2020 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelsauter michaelsauter michaelsauter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sino92 @michaelsauter