Bugfix/big table content overflow #32
Conversation
There was a problem hiding this comment.
@louis-sanchez Due to the exhaustive changes... did you run the templates through an HTML validator? Also, why are indentations not consistent? Templates are supposed to be clean. You'll need a reviewer that verifies for every changed block that the section references have not changed erroneously.
| @@ -436,10 +440,18 @@ | |||
| <div class="page"> | |||
| <h2 id="section_6"><span>6</span>Definitions and Abbreviations</h2> | |||
| <h3 id="section_6_1"><span>6.1</span>Definitions</h3> | |||
| <p>{{{data.sections.sec6s1.content}}}</p> | |||
| <table> | |||
There was a problem hiding this comment.
this <table> is correctly indented. the <p> was not.
| @@ -391,7 +441,11 @@ | |||
| {{/each}} | |||
| </table> | |||
| {{/if}} | |||
| <p>{{{data.sections.sec15.content}}}</p> | |||
There was a problem hiding this comment.
incorrect <p> formatting
|
@louis-sanchez there was a PR merged in the meantime which requires you to create an entry in the Changelog.md. Entries need to follow a certain format. Please look here for examples: https://github.com/opendevstack/ods-jenkins-shared-library/blob/master/CHANGELOG.md |
| @@ -315,17 +343,29 @@ | |||
| <li>All executed acceptance test cases</li> | |||
| <li>Discrepancy log</li> | |||
| </ul> | |||
| <p>{{{data.sections.sec12.content}}}</p> | |||
There was a problem hiding this comment.
<table> is now indented correctly. <p> was not.
| @@ -315,17 +348,29 @@ | |||
| <li>All executed acceptance test cases</li> | |||
| <li>Discrepancy log</li> | |||
| </ul> | |||
| <p>{{{data.sections.sec12.content}}}</p> | |||
There was a problem hiding this comment.
<table> is now indented correctly. <p> was not.
| @@ -315,17 +351,30 @@ | |||
| <li>All executed acceptance test cases</li> | |||
| <li>Discrepancy log</li> | |||
| </ul> | |||
| <p>{{{data.sections.sec12.content}}}</p> | |||
There was a problem hiding this comment.
<table> is now indented correctly. <p> was not.
| @@ -315,17 +351,29 @@ | |||
| <li>All executed acceptance test cases</li> | |||
| <li>Discrepancy log</li> | |||
| </ul> | |||
| <p>{{{data.sections.sec12.content}}}</p> | |||
There was a problem hiding this comment.
<table> is now indented correctly. <p> was not.
|
@louis-sanchez SSDS templates are still not in shape. Did you do the HTML validation? Please let us know when the review can happen. |
louis-sanchez
force-pushed
the
bugfix/big-table-content-overflow
branch
from
9034b91
to
53f3ba3
Compare
Tables are not rendered correctly when the column content is too long. This fix forces text to wrap and show correctly