Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missed rows in IVP template #52

Merged
merged 5 commits into from
Aug 6, 2021
Merged

Conversation

jorge-romero
Copy link
Contributor

@jorge-romero jorge-romero commented Jul 30, 2021

In the IVP template, there were two row missing in the conclussion table, with this fix we add the missing information as exists in the word template of the document

Copy link
Member

@metmajer metmajer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jorge-romero Note sure about this one?

Enter additional information, if necessary:

@jorge-romero
Copy link
Contributor Author

@jorge-romero Note sure about this one?

Enter additional information, if necessary:

I'll ask for confirmation regarding that last sentence. It appear in the word template in that way but let me confirm that.

@metmajer
Copy link
Member

metmajer commented Aug 3, 2021

@jorge-romero I figured it was in the Word template ;-) But our automated service won't allow such additional information to be entered.

@jorge-romero
Copy link
Contributor Author

@metmajer After checking with the right people and have their approval on the generated pdf, the table have been removed from the template and a subsituted by a message that indicates where to find the conclusions.

@metmajer
Copy link
Member

metmajer commented Aug 5, 2021

@jorge-romero great :) we also need this in 4.x, don't forget.

@metmajer metmajer merged commit 9c82164 into master Aug 6, 2021
@metmajer metmajer deleted the fix/missing-rows-in-IVP-template branch August 6, 2021 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants