Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ods-deployments file repeats image in mono repository setup #1011

Closed
albertpuente opened this issue Jun 13, 2023 · 5 comments · Fixed by #1023
Closed

ods-deployments file repeats image in mono repository setup #1011

albertpuente opened this issue Jun 13, 2023 · 5 comments · Fixed by #1023
Labels
bug Something isn't working

Comments

@albertpuente
Copy link
Contributor

albertpuente commented Jun 13, 2023

Describe the bug
When using a single component with multiple images being built with odsComponentStageBuildOpenShiftImage() and deployed via Helm, the ods-deployments file does not properly reflect the names and hashes of the different images.

To Reproduce
Steps to reproduce the behavior:

  1. Create a component with multiple images being built.
  2. Use helm as the tool to deploy such component by adding a chart.
  3. Deploy the comoponent to dev.

Expected behavior
The ods-deployments.json file of the component should contain different images instead of repeating the first image.

Log Output (ensure to remove any confidential information like tokens, project names, etc.
See excerpts below:

{
    "deployments": {
        "pid-backend": {
            "containers": {
                "backend": "pid-backend@sha256:786b248f3e783777f1ea6eb2243cba975ff28ed8ee7fd0fc7f951a463fbde242"
            },
            "deploymentMean": {
                "type": "helm",
                ...
            }
        },
        "pid-frontend": {
            "containers": {
                "backend": "pid-backend@sha256:786b248f3e783777f1ea6eb2243cba975ff28ed8ee7fd0fc7f951a463fbde242"
            },
            "deploymentMean": {
                "type": "helm",
                ...
            }
        },
        "pid-cache": {
            "containers": {
                "backend": "pid-backend@sha256:786b248f3e783777f1ea6eb2243cba975ff28ed8ee7fd0fc7f951a463fbde242"
            },
            "deploymentMean": {
                "type": "helm",
                ...
            }
        }
    },
    "CREATED_BY_BUILD": "0.1.2/1324"
}

Affected version (please complete the following information):

  • OpenShift: 3.12
  • OpenDevStack 4.x

Additional context
This problem was reported by @gerardcl.

@albertpuente albertpuente added the bug Something isn't working label Jun 13, 2023
@metmajer
Copy link
Member

Hi @serverhorror, looks like we have a bug. Can you look into this?

@serverhorror
Copy link
Contributor

@metmajer Sure thing! Who from the core dev team should I work with so you can better maintain this in the future?

@metmajer
Copy link
Member

metmajer commented Jun 20, 2023

@serverhorror we have a good amount of topics to work on. We don't expect that many bugs come up from your integration, do we? Overall, ownership remains on you for the time being.

serverhorror added a commit to serverhorror/ods-jenkins-shared-library that referenced this issue Jul 24, 2023
This allows us to extract the relevant pod data
in case there are multiple pods in a mono-repo like rollout

fixes opendevstack#1011
fixes opendevstack#1011
@serverhorror
Copy link
Contributor

I think #1023, #1025 and #1026 might all be related.

@jafarre-bi, @jorge-romero, @hrcornejo -- can you provide feedback on this?

(I hope I pinged the right people).

@serverhorror
Copy link
Contributor

I think #1023, #1025 and #1026 might all be related.

@metmajer, @jafarre-bi, @jorge-romero, @hrcornejo -- can you provide feedback on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants