-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Images are not tagged as latest when using Helm #1027
Comments
TL;DR -- If it doesn't block you I would like to avoid setting
If I recall correctly this is on purpose. I think the decision for the difference was based on:
It does happen in the build stage. It tags with The
If you really only want to build and image, that is pretty unrelated to Helm at all. I'd drop everything that is related to tailor or Helm and just do something along those lines:
|
As discussed with @serverhorror, there is no technically need to change anything since Also, I won't close this ticket yet as it is supposed to serve as a reminder to @serverhorror to add some documentation about this behaviour. |
fixes Images are not tagged as latest when using Helm opendevstack#1027
fixes Images are not tagged as latest when using Helm opendevstack#1027
I provisioned a docker plain component and am using the Dockerfile and the Jenkins stage odsComponentStageBuildOpenShiftImage to just build the image. I deleted the DeploymentConfig in OCP because I really just want to build the image to have it in the registry. Additionally, I added a couple of kubernetes resources (a CronJob and a PVC yaml) into the repo and manage this via Helm (via stage odsComponentStageRolloutOpenShiftDeployment).
Since I added the Helm stuff my above image doesn't get tagged as latest anymore, which is unfortunate because I use this image in the CronJob. I looked into the ods code and saw that when using the tailorDeploymentStrategy it tags the image as latest here: ods-jenkins-shared-library/src/org/ods/component/TailorDeploymentStrategy.groovy at master · opendevstack/ods-jenkins-shared-library (github.com) while the same does not happen in the helmDeploymentStrategy at all.
Regarding this, I have the following questions:
To circumvent the issue, I'm currently setting the imageTag myself:
That works, but it is error prone. In case I update the Dockerfile but forget to raise these versions before pushing, it would overwrite the previous image in the registry. I would rather have it automatically tagged as latest.
The text was updated successfully, but these errors were encountered: