Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve deployment stage #144

Closed
michaelsauter opened this issue Oct 21, 2019 · 0 comments · Fixed by #147
Closed

Improve deployment stage #144

michaelsauter opened this issue Oct 21, 2019 · 0 comments · Fixed by #147
Assignees
Labels
enhancement New feature or request

Comments

@michaelsauter
Copy link
Member

There are a couple of improvements I'm planning to implement for the deployment stage:

  • Right now, the deployment assumes that ImageStream and DeploymentConfig of a certain name exist, and it does not fail in a friendly way if this is not the case.
  • The deployment happens because the latest tag is updated. The command used for that is deprecated (see Tagging images is deprecated #67), and more generally, it assumes that an image trigger is present which might not be the case.
  • There is no deployment timeout - right now the step can take very long and the user cannot control how long it is allowed to take.
  • Since 1.2, the result of the deployment is checked (which is awesome as it fails the build when the deployment fails - combined with health checks that allows for a very robust rollout), however the code relies on a lot of oc output, which is brittle (see e.g. Seldom error in stageDeployToOpenshift (ArrayIndexOutOfBounds)- when checking for new deployment #142) and does quite a few calls, which can be optimised.
  • Finally, it would be nice to expose the "building blocks" of deployment so that quickstarters which need more control over the deployment (e.g. because they have two DeploymentConfig resources) can use those building blocks.

I have a prototype of this ready and will give it some test time this week and then open a PR.

@michaelsauter michaelsauter added the enhancement New feature or request label Oct 21, 2019
@michaelsauter michaelsauter self-assigned this Oct 21, 2019
michaelsauter added a commit to BIX-Digital/ods-jenkins-shared-library that referenced this issue Oct 25, 2019
michaelsauter added a commit to BIX-Digital/ods-jenkins-shared-library that referenced this issue Oct 25, 2019
michaelsauter added a commit to BIX-Digital/ods-jenkins-shared-library that referenced this issue Oct 25, 2019
@michaelsauter michaelsauter moved this from To do to In progress in OpenDevStack 2.0 Oct 25, 2019
@michaelsauter michaelsauter moved this from In progress to Done in OpenDevStack 2.0 Oct 31, 2019
michaelsauter pushed a commit to BIX-Digital/ods-jenkins-shared-library that referenced this issue Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant