Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract stages into src #215

Closed
michaelsauter opened this issue Apr 1, 2020 · 0 comments · Fixed by #221
Closed

Extract stages into src #215

michaelsauter opened this issue Apr 1, 2020 · 0 comments · Fixed by #221
Assignees
@michaelsauter
Labels
enhancement New feature or request

Comments

@michaelsauter
Copy link
Member

Right now the logic of the stages is defined in vars/. It would be better to instantiate a new object there, and have it do the logic. That should be easier to test and allows to organise the code better.,
@michaelsauter michaelsauter added the enhancement New feature or request label Apr 1, 2020
@michaelsauter michaelsauter self-assigned this Apr 1, 2020
michaelsauter added a commit to BIX-Digital/ods-jenkins-shared-library that referenced this issue Apr 1, 2020
@michaelsauter
Extract stages into classes
85f95ee 
That way, it is easier to organise code.

This change also:

* Moves everything related to building/deploying apps into org.ods.app
* Moves `build_service` to `services`
* Adds more tests
* Fixes opendevstack#218
* Closes opendevstack#217
* Closes opendevstack#218
* Closes opendevstack#215
@michaelsauter michaelsauter mentioned this issue Apr 1, 2020
Merged
michaelsauter added a commit to BIX-Digital/ods-jenkins-shared-library that referenced this issue Apr 2, 2020
@michaelsauter
Extract stages into classes
2cd6ae2 
That way, it is easier to organise code.

This change also:

* Moves everything related to building/deploying apps into org.ods.app
* Moves `build_service` to `services`
* Adds more tests
* Fixes opendevstack#218
* Closes opendevstack#217
* Closes opendevstack#218
* Closes opendevstack#215
michaelsauter added a commit to BIX-Digital/ods-jenkins-shared-library that referenced this issue Apr 2, 2020
@michaelsauter
Extract stages into classes
d216ae1 
That way, it is easier to organise code.

This change also:

* Moves everything related to building/deploying components into org.ods.component
* Moves `build_service` to `services`
* Adds more tests
* Fixes opendevstack#218
* Closes opendevstack#217
* Closes opendevstack#218
* Closes opendevstack#215
michaelsauter added a commit to BIX-Digital/ods-jenkins-shared-library that referenced this issue Apr 2, 2020
@michaelsauter
Extract stages into classes
b49cf4c 
That way, it is easier to organise code.

This change also:

* Moves everything related to building/deploying components into org.ods.component
* Moves `build_service` to `services`
* Adds more tests
* Fixes opendevstack#218
* Closes opendevstack#217
* Closes opendevstack#216
* Closes opendevstack#215
michaelsauter added a commit to BIX-Digital/ods-jenkins-shared-library that referenced this issue Apr 2, 2020
@michaelsauter
Extract stages into classes
99cf51c 
That way, it is easier to organise code.

This change also:

* Moves everything related to building/deploying components into org.ods.component
* Moves `build_service` to `services`
* Adds more tests
* Fixes opendevstack#218
* Closes opendevstack#217
* Closes opendevstack#216
* Closes opendevstack#215
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelsauter michaelsauter

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Extract stages into classes BIX-Digital/ods-jenkins-shared-library
1 participant
@michaelsauter