Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRO Test / Build stage duplicate lots of code #359

Closed
clemensutschig opened this issue May 29, 2020 · 3 comments · Fixed by #365
Closed

MRO Test / Build stage duplicate lots of code #359

clemensutschig opened this issue May 29, 2020 · 3 comments · Fixed by #365
Assignees
Labels
bug Something isn't working

Comments

@clemensutschig
Copy link
Member

clemensutschig commented May 29, 2020

Describe the bug
code duplication in the two stages ...

https://github.com/opendevstack/ods-jenkins-shared-library/blob/master/src/org/ods/orchestration/BuildStage.groovy#L82-L111

https://github.com/opendevstack/ods-jenkins-shared-library/blob/master/src/org/ods/orchestration/TestStage.groovy#L125-L154

This should be cleanly refactored into the JunitTestReportsUsecase - to remove clutter from the stages...

Also this jira.XXX https://github.com/opendevstack/ods-jenkins-shared-library/blob/master/src/org/ods/orchestration/TestStage.groovy#L62-L75 should go away

@clemensutschig clemensutschig added the bug Something isn't working label May 29, 2020
@clemensutschig
Copy link
Member Author

@martsec / @metmajer - is this something on your plate? - I know this will cause some good test-rework, ... but we should try to get all this clutter out of the stages.

@martsec
Copy link
Contributor

martsec commented May 29, 2020

That is not on our plate right now

@clemensutschig
Copy link
Member Author

clemensutschig commented May 29, 2020 via email

@clemensutschig clemensutschig self-assigned this Jun 2, 2020
@clemensutschig clemensutschig added this to To Do in OpenDevStack 3.0 via automation Jun 2, 2020
@clemensutschig clemensutschig moved this from To Do to In Progress in OpenDevStack 3.0 Jun 2, 2020
OpenDevStack 3.0 automation moved this from In Progress to Done Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants