cURL command fix for the sonarqube quality gate report retrieval #1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerardcl
added
bug
…eport get request
gerardcl
force-pushed
the
fix/sonarqube-quality-gate-branch-target
branch
from
7688d2b
to
b0165db
Compare
braisvq1996
approved these changes
Jul 13, 2023
This was referenced Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a fully functional fix by using flags for URL encoded parameters when using cURL CLI, in this case for the retrieval of the sonarqube quality gate report. Followup bug fix for #1016.
Indeed now we use flags for all attributes in this cURL command, and I would strongly recommend doing that and avoid weird URL encoding bugs, for example.