Reduce context surface #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stage authors do not need this information. If there is a case where they do, they can simply configure the option explicitly from their Jenkinsfile, in which case they know and control the value.
Those variables are only needed for the pipeline, not for stage authors.
michaelsauter
force-pushed
the
refactor/reduce-context-surface
branch
from
73622ab
to
5a907af
Compare
clemensutschig
approved these changes
Apr 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #252.
I know that the pipeline is very ugly now, but at least the context looks a little better. I'll work on making the pipeline better in the future.
Next up is: