Feature/svc common usage (Jenkins / Nexus / GitService) #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clemensutschig
changed the title
clemensutschig
changed the title
|
@martsec @georgfedermann - fyi, the only thing that changed are packages ... |
michaelsauter
previously approved these changes
May 11, 2020
| @@ -296,4 +296,11 @@ class OpenShiftService { | |||
| return images | |||
| } | |||
|
|
|||
| String getOriginUrlFromBuildConfig (String project, String bcName) { | |||
There was a problem hiding this comment.
We could still use the instance variable project, right? I know that how it is used from the pipeline, here the project is e.g. foo-cd and for the other methods it is e.g. foo-dev, but that shouldn't matter. You anyway instantiate a new OpenShiftService just to call this method, so you can pass the project to the constructor there ...
There was a problem hiding this comment.
Anyway, I can also do this cleanup later on - I need to work on the OpenShiftService this week anyway.
There was a problem hiding this comment.
@michaelsauter - I would leave this to you .. to do this in one big shot ..
michaelsauter
approved these changes
May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also ensures that common services are really shared at runtime (and not blindly overwritten in the 'component' pipeline) .. which uncovered a whole set of more issues (Pipelinesteps, NPE,.. :))
Tested both standalone (with flask and also in the MRO context) - both work now :)