Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various smaller issues #352

Merged

Conversation

michaelsauter
Copy link
Member

  • Adds debug statement when project / component is auto-resolved (there was a related failure which I could not reproduce now, but at least one would see more info when debug is enabled now)
  • Makes overriding of projectKey and projectName consistent (otherwise e.g. ods-doc-gen-svc QS fails because the behaviour of sonar-scanner and cnesreport.jar was inconsistent). On a side note, I realised that overriding projectKey is, technically speaking, a backwards incompatible change. However, my understanding is that you want to enforce it, right @clemensutschig?
  • Adds a check if the target directory exists. @clemensutschig do you remember why we changed it from out, which is what I had initially, to the value of componentId? If it doesn't need to be componentId, then I actually propose to make a further change and switch back to out to be really safe.

Otherwise one runs into Git issues because "untracked files would be
overwritten by checkout". This might be hard to understand, so aborting
early is better.
@michaelsauter michaelsauter added the bug Something isn't working label May 25, 2020
@michaelsauter michaelsauter self-assigned this May 25, 2020
@clemensutschig
Copy link
Member

  • Adds a check if the target directory exists. @clemensutschig do you remember why we changed it from out, which is what I had initially, to the value of componentId? If it doesn't need to be componentId, then I actually propose to make a further change and switch back to out to be really safe.

in the fork case - there was an error, as the directory already existed, I believe ...

@michaelsauter michaelsauter merged commit b9b76f2 into opendevstack:master May 25, 2020
@michaelsauter michaelsauter added this to Done in OpenDevStack 3.0 via automation May 25, 2020
@michaelsauter michaelsauter deleted the fix/project-autoresolve branch May 25, 2020 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants