-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stage to import image and automatically import if possible #400
Add stage to import image and automatically import if possible #400
Conversation
2d019fe
to
e467413
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is amazing @michaelsauter
One small comment though - I am wondering if this would not break MRO - if MRO expects to build an image - and in reality it's not built ... or deployed, or ....
Awesome addition! I don't have time to look into reviewing this in depth. However I did not see any issues on a cursory review. |
@clemensutschig I thought about this, and decided that as a first step, we just disable the functionality when in an orchestration context (see https://github.com/opendevstack/ods-jenkins-shared-library/pull/400/files#diff-c50f3cdbc0d4a66242907069707b7463R17-R23). Maybe this is even a long-term solution, as the orchestration pipeline has its own logic to bypass building a component altogether. |
* New stage `odsComponentStageImportOpenShiftImage`. * New "special" stage `odsComponentStageImportOpenShiftImageOrElse` which either imports an image or executes the given closure. * Images are now tagged with the short Git SHA, dropping the Jenkins build number prefix.
e467413
to
f518792
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great!!!
also loving the push for ff merge!
odsComponentStageImportOpenShiftImage
.odsComponentStageImportOpenShiftImageOrElse
which either imports an image or executes the given closure.
build number prefix.
Example usage:
This allows users exactly which steps to skip when an image can be imported. Further, it allows to use the "import image stage" as a standalone feature as well.