Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the workaround for NPE resolving issues #660

Merged
merged 3 commits into from
Jul 29, 2021
Merged

Remove the workaround for NPE resolving issues #660

merged 3 commits into from
Jul 29, 2021

Conversation

jafarre-bi
Copy link
Contributor

issues

@jafarre-bi jafarre-bi changed the title Remove the workaround for NPE resolving issues, both at plugin and shared-library levels Remove the workaround for NPE resolving issues Jun 1, 2021
metmajer
metmajer previously approved these changes Jun 1, 2021
View reviewed changes
Copy link
Member

@metmajer metmajer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jafarre-viewnext. Please wait until @s2oBCN has merged the new test cases to verify the correct behavior of this change.

@jafarre-bi
Copy link
Contributor Author

Thanks @jafarre-viewnext. Please wait until @s2oBCN has merged the new test cases to verify the correct behavior of this change.

Yes, I'll wait. It also needs to be in sync with the corresponding change in the plugin.

@metmajer
Copy link
Member

metmajer commented Jun 15, 2021 •
edited

@jafarre-viewnext you ping when you need something :)

@metmajer
Copy link
Member

@jafarre-viewnext is this still something you want to merge? Let's please close either way. Thanks!

@jafarre-bi
Copy link
Contributor Author

@jafarre-viewnext is this still something you want to merge? Let's please close either way. Thanks!

@metmajer Yes, this was pending having the test framework by @s2oBCN , but it can be merged any time.

@jafarre-bi
Copy link
Contributor Author

The corresponding change to the plugin has already been merged. Should I merge this one, too?

@jafarre-bi jafarre-bi requested a review from metmajer July 29, 2021 13:03
@jafarre-bi jafarre-bi merged commit b698b73 into master Jul 29, 2021
@jafarre-bi jafarre-bi deleted the fix/EDPC-763 branch July 29, 2021 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metmajer metmajer metmajer approved these changes

@angelmp01 angelmp01 Awaiting requested review from angelmp01

@hrcornejo hrcornejo Awaiting requested review from hrcornejo

@jorge-romero jorge-romero Awaiting requested review from jorge-romero

@s2oBCN s2oBCN Awaiting requested review from s2oBCN

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jafarre-bi @metmajer