Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix triple bug reporting, detected in E2E test #757

Closed
wants to merge 16 commits into from

Conversation

petod108
Copy link
Contributor

@petod108 petod108 commented Nov 9, 2021

fix problem with test reporting and added more logs in order to understand better the process

  • Fixing bug:
    When executing step "deploying on QA"
    And there is one bug in test project-
    Then after execution in Jira exist three same bugs
    and from those one one is linked with the test Jira ticket.

which was produced by keeping same data structure for every type of test

  • added also better logging
  • and reducing size of function because the same code is repeated for every type of test (Acceptance, Installation, Integration)

@metmajer
Copy link
Member

metmajer commented Nov 9, 2021

@petod108 @s2oBCN you are making changes to the core of test handling. Please take the time to properly describe what you are intending to do here — and add a proper name for the issue, too.

@petod108 petod108 changed the title Bugifx/jira release test Fix reporting 3 bugs instead of just one, because of Map duplicity Nov 10, 2021
@petod108
Copy link
Contributor Author

Fixing bug:
When executing step "deploying on QA"
And there is one bug in test project-
Then after execution in Jira exist three same bugs
and from those one one is linked with the test Jira ticket.

@petod108 petod108 changed the title Fix reporting 3 bugs instead of just one, because of Map duplicity fix triple bug reporting, detected in E2E test Nov 10, 2021
@petod108 petod108 requested review from hrcornejo, metmajer and s2oBCN and removed request for s2oBCN and jafarre-bi November 11, 2021 16:28
]
]
def data = [:]
data.tests = globalData.tests.clone()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@petod108 is the clone needed? This could be memory expensive.

Comment on lines 47 to 49
data.tests.each {
it.value = getTestResults(steps, repo, it.key.capitalize())
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@petod108 I think the other reads and communicates the intention much more clearly

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@petod108 code is principally fine, but at least a comment would help.

def globalData = [
tests: [
acceptance: globalStructure,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code was reason for bug behavior

metmajer
metmajer previously approved these changes Nov 12, 2021
@metmajer
Copy link
Member

@petod108 please create a cherry-pick PR into 4.x as well

@petod108
Copy link
Contributor Author

Yes, I will do.
I found there in this PR is problem with NonCPS

Peter Durisin added 2 commits November 12, 2021 17:39
@petod108 petod108 requested review from metmajer and removed request for hrcornejo, s2oBCN and metmajer November 12, 2021 21:54
@petod108
Copy link
Contributor Author

I create another branch with PR because I did pull master (because of my E2E testing) and afterward revert, which "destroyed" this branch.

@petod108 petod108 closed this Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants