-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix triple bug reporting, detected in E2E test #757
Conversation
Fixing bug: |
…shared-library into bugifx/jiraReleaseTest # Conflicts: # CHANGELOG.md
…test results in Jira'
] | ||
] | ||
def data = [:] | ||
data.tests = globalData.tests.clone() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@petod108 is the clone needed? This could be memory expensive.
data.tests.each { | ||
it.value = getTestResults(steps, repo, it.key.capitalize()) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@petod108 I think the other reads and communicates the intention much more clearly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@petod108 code is principally fine, but at least a comment would help.
…shared-library into bugifx/jiraReleaseTest
def globalData = [ | ||
tests: [ | ||
acceptance: globalStructure, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code was reason for bug behavior
@petod108 please create a cherry-pick PR into 4.x as well |
Yes, I will do. |
…jenkins-shared-library into bugifx/jiraReleaseTest" This reverts commit f851a8e, reversing changes made to b77c848.
I create another branch with PR because I did pull master (because of my E2E testing) and afterward revert, which "destroyed" this branch. |
fix problem with test reporting and added more logs in order to understand better the process
When executing step "deploying on QA"
And there is one bug in test project-
Then after execution in Jira exist three same bugs
and from those one one is linked with the test Jira ticket.
which was produced by keeping same data structure for every type of test