Fix/break long strings in SSDS - 4.x #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorge-romero
requested review from
hrcornejo,
s2oBCN,
jafarre-bi and
metmajer
clemensutschig
changed the title
clemensutschig
approved these changes
Nov 12, 2021
s2oBCN
pushed a commit
that referenced
this pull request
Nov 30, 2021
* Change characters in csv output to prevent long strings * Update tests * Update CHANGELOG.md
s2oBCN
pushed a commit
that referenced
this pull request
Dec 1, 2021
* Change characters in csv output to prevent long strings * Update tests * Update CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In SSDS the list of PR use to have long strings like email, urls.
With this fix, we add some breakable characters that are not renderized in the emails and urls so the conversion from html to pdf can make them fit in the table.