fix: removed logger from NonCPS to CPS #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 12, 2021 22:29
fix: CodeNarc error
clemensutschig
previously approved these changes
Nov 15, 2021
|
added 2 commits
November 16, 2021 01:54
clemensutschig
previously approved these changes
Nov 16, 2021
s2oBCN
reviewed
Nov 30, 2021
| @@ -3,7 +3,7 @@ | |||
| ## Unreleased | |||
|
|
|||
| ## [4.0] - 2021-05-11 | |||
|
|
|||
| - Prevent Jenkins nonCPS error after reporting bug ([#776](https://github.com/opendevstack/ods-jenkins-shared-library/pull/776)) | |||
There was a problem hiding this comment.
Please move this line above , is not for 4.0
| @@ -325,6 +326,9 @@ class DocumentHistory { | |||
| this.allIssuesAreValid = true | |||
|
|
|||
| def versionMap = this.computeEntryData(jiraData, projectVersion, keysInDocument) | |||
| if (!this.allIssuesAreValid){ | |||
There was a problem hiding this comment.
let me talk online about this code
| @@ -3,7 +3,7 @@ | |||
| ## Unreleased | |||
|
|
|||
| ## [4.0] - 2021-05-11 | |||
|
|
|||
| - Prevent Jenkins nonCPS error after reporting bug ([#776](https://github.com/opendevstack/ods-jenkins-shared-library/pull/776)) | |||
There was a problem hiding this comment.
Please move this above, this is not 4.x
# Conflicts: # CHANGELOG.md # src/org/ods/orchestration/util/DocumentHistory.groovy
s2oBCN
approved these changes
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moved logger from NonCPS to upper CPS function.
If logger is used in NonCPS then there is error:
DEBUG: Parsing jira data to document history
expected to call org.ods.orchestration.util.DocumentHistory.computeEntryData but wound up catching org.ods.util.Logger.warn; see: https://jenkins.io/redirect/pipeline-cps-method-mismatches/
...
WARN: Error occured within the orchestration pipeline: Error: Creating document of type 'CFTR' for project 'tes96' in phase 'Test' and stage 'PRE_END' has failed: Could not find matching constructor for: org.ods.orchestration.util.DocumentHistoryEntry(java.lang.String, java.lang.Long, java.lang.String, java.lang.String, java.lang.String)