Fix RM: *found unexecuted Jira tests* error during promote2Production when functional test only runs on D and QA #832
Conversation
| @@ -299,6 +299,16 @@ class JiraUseCase { | |||
| } | |||
| } | |||
|
|
|||
| private boolean mustRun(testIssue) { | |||
| return !(project.buildParams?.targetEnvironmentToken == 'P' && | |||
There was a problem hiding this comment.
@jafarre-viewnext it may be worth to factor the environment part into a Project method
There was a problem hiding this comment.
Just committed a change. Is this what you had in mind?
| [ | ||
| Project.TestType.ACCEPTANCE.toLowerCase(), | ||
| Project.TestType.INTEGRATION.toLowerCase() | ||
| ] |
There was a problem hiding this comment.
Does this mean TestType.UNIT must also be executed in P?
There was a problem hiding this comment.
Yes, this is what the ticket said. Should I ignore everything that is not explicitly marked as INSTALLATION?
There was a problem hiding this comment.
Yes, the ticket only mentions those two (acceptance and integration). But I do wonder if we should consider unit here or not, just in case. @metmajer
There was a problem hiding this comment.
@albertpuente @jafarre-viewnext Unit tests are not executed in P, you can add it to the list.
There was a problem hiding this comment.
Ok, in this case it will be clearer to reverse the check and require only tests of type INSTALLATION
|
@albertpuente - what we could do is to reconfigure your jenkins to pick up this branch / from github - to see if it's working :) |
|
Yes, I will start a new version now. |
|
I confirm the pipeline now runs from WIP -> PROD with this fix. Tests are also updated accordingly (P shows UNEXECUTED). |
|
:) Thanks @albertpuente @jafarre-viewnext @s2oBCN @clemensutschig ! |
|
this is mega cool - we need this for master / 4.x and 3.x :) |
… when functional test only runs on D and QA (#832) (#834) * Fix RM: *found unexecuted Jira tests* error during promote2Production when functional test only runs on D and QA (#832) * Ignore unexecuted acceptance and integration tests when deploying into prod Co-authored-by: zxBCN Farre_Basurte,Juan_Antonio (IT EDS) EXTERNAL <juan_antonio.farre_basurte.ext@boehringer-ingelheim.com> (cherry picked from commit 3e80750)
Ignore unexecuted acceptance and integration tests when deploying into prod