Removes DIL_P doc. #914
Merged
Removes DIL_P doc. #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
June 29, 2022 08:24
|
@metmajer who from QA approved this?! |
No, QA has not approved it. |
angelmp01
previously approved these changes
Jun 30, 2022
victorpablosceruelo
changed the base branch from
master
to
feature/flexible_r2p_jira_workflow
|
We changed the base (target) branch to feature/flexible_r2p_jira_workflow |
victorpablosceruelo
requested review from
clemensutschig,
jafarre-bi,
jorge-romero and
metmajer
|
We need to merge this "remove DIL_P doc" to continue with the development process. Thanks!! |
|
@clemensutschig @victorpablosceruelo I clarified this with the quality team. Since the DIL only contains Integration and Acceptance tests and none of them is documented in Prod, we can safely delete its creation (for the Prod environment only, for QA we still need it). Installation test errors during Prod deployments will be covered in the IVR template. Our documentation will offer the manual creation of a DIL if needed. |
metmajer
approved these changes
Jul 20, 2022
3 tasks
victorpablosceruelo
added a commit
that referenced
this pull request
Aug 16, 2022
* Developer preview uses the release branch if exists, the branch in Release Manager's metadata.yml cfg if not. (#917) * changelog * Logging we need to see what is going on. * Small refactor to clarify what source code does. * Use release branch if it exists, in dev mode. * Checkout release branch for developer preview if available. Co-authored-by: Victor Pablos Ceruelo <victor.pablos_ceruelo.ext@boehringer-ingelheim.com> * Feature/edpc 1323 dev preview from release branch if exists (#920) * changelog * Logging we need to see what is going on. * Small refactor to clarify what source code does. * Use release branch if it exists, in dev mode. * Checkout release branch for developer preview if available. * Log in debug mode undone jira issues and chapters. * Log in debug mode comment added to Jira Release Status * Do branch checkout for non-release repos too-. * gitReleaseBranch id needs to be saved for future usage in pipeline. * If release manager branch is master, other comp. branch is defined in yaml. * Need to push to the branch we are looking for. * Initialize map before using it. * typo * Tests for InitStage * tests for MROPipelineUtil. * changelog Co-authored-by: Victor Pablos Ceruelo <victor.pablos_ceruelo.ext@boehringer-ingelheim.com> * Removes DIL_P doc. (#914) * Removes DIL_P doc. * Trying to log what is being sent to jira * Correct way to log variable. * Pretty print map using json format. * Revert "Correct way to log variable." This reverts commit 8ae309a. * Revert "Trying to log what is being sent to jira" This reverts commit 0367847. * jcenter is no more available. * Removes from test checking that DIL_P is generated. * changelog Co-authored-by: zxBCN Pablos_Ceruelo,Victor (IT EDS) EXTERNAL <victor.pablos_ceruelo.ext@boehringer-ingelheim.com> * Sets rePromote field to true by default + tests. * Check if tag exists. * Fixes tests readability. * Need to eval locally if tag exists before creating it. * edpc 1323 dev preview from release branch if exists (#925) * changelog * Logging we need to see what is going on. * Small refactor to clarify what source code does. * Use release branch if it exists, in dev mode. * Checkout release branch for developer preview if available. * Log in debug mode undone jira issues and chapters. * Log in debug mode comment added to Jira Release Status * Do branch checkout for non-release repos too-. * gitReleaseBranch id needs to be saved for future usage in pipeline. * If release manager branch is master, other comp. branch is defined in yaml. * Need to push to the branch we are looking for. * Initialize map before using it. * typo * Tests for InitStage * tests for MROPipelineUtil. * changelog * Reverts problematic change. Co-authored-by: Victor Pablos Ceruelo <victor.pablos_ceruelo.ext@boehringer-ingelheim.com> * Feature/edpc 1335 allow to redeploy in D, Q and P (#926) * Sets rePromote field to true by default + tests. * Check if tag exists. * Fixes tests readability. * Need to eval locally if tag exists before creating it. * changelog Co-authored-by: zxBCN Pablos_Ceruelo,Victor (IT EDS) EXTERNAL <victor.pablos_ceruelo.ext@boehringer-ingelheim.com> * changelog * Feature/edpc 1335 set repromote to true if unset (#927) * Sets rePromote field to true by default + tests. * Check if tag exists. * Fixes tests readability. * Need to eval locally if tag exists before creating it. * changelog Co-authored-by: zxBCN Pablos_Ceruelo,Victor (IT EDS) EXTERNAL <victor.pablos_ceruelo.ext@boehringer-ingelheim.com> Co-authored-by: Martinez,Angel (IT EDS) BI-ES-S <angel_2.martinez@boehringer-ingelheim.com> * Force push in RM tags with redeploy Co-authored-by: Victor Pablos Ceruelo <victor.pablos_ceruelo.ext@boehringer-ingelheim.com> Co-authored-by: Martinez,Angel (IT EDS) BI-ES-S <angel_2.martinez@boehringer-ingelheim.com> Co-authored-by: Jorge Romero <jorge.romeropalma@gmail.com> Co-authored-by: Rodriguez,Hector (IT EDS) <hector_2.rodriguez@boehringer-ingelheim.com>
victorpablosceruelo
pushed a commit
that referenced
this pull request
Aug 16, 2022
* Developer preview uses the release branch if exists, the branch in Release Manager's metadata.yml cfg if not. (#917) * changelog * Logging we need to see what is going on. * Small refactor to clarify what source code does. * Use release branch if it exists, in dev mode. * Checkout release branch for developer preview if available. Co-authored-by: Victor Pablos Ceruelo <victor.pablos_ceruelo.ext@boehringer-ingelheim.com> * Feature/edpc 1323 dev preview from release branch if exists (#920) * changelog * Logging we need to see what is going on. * Small refactor to clarify what source code does. * Use release branch if it exists, in dev mode. * Checkout release branch for developer preview if available. * Log in debug mode undone jira issues and chapters. * Log in debug mode comment added to Jira Release Status * Do branch checkout for non-release repos too-. * gitReleaseBranch id needs to be saved for future usage in pipeline. * If release manager branch is master, other comp. branch is defined in yaml. * Need to push to the branch we are looking for. * Initialize map before using it. * typo * Tests for InitStage * tests for MROPipelineUtil. * changelog Co-authored-by: Victor Pablos Ceruelo <victor.pablos_ceruelo.ext@boehringer-ingelheim.com> * Removes DIL_P doc. (#914) * Removes DIL_P doc. * Trying to log what is being sent to jira * Correct way to log variable. * Pretty print map using json format. * Revert "Correct way to log variable." This reverts commit 8ae309a. * Revert "Trying to log what is being sent to jira" This reverts commit 0367847. * jcenter is no more available. * Removes from test checking that DIL_P is generated. * changelog Co-authored-by: zxBCN Pablos_Ceruelo,Victor (IT EDS) EXTERNAL <victor.pablos_ceruelo.ext@boehringer-ingelheim.com> * Sets rePromote field to true by default + tests. * Check if tag exists. * Fixes tests readability. * Need to eval locally if tag exists before creating it. * edpc 1323 dev preview from release branch if exists (#925) * changelog * Logging we need to see what is going on. * Small refactor to clarify what source code does. * Use release branch if it exists, in dev mode. * Checkout release branch for developer preview if available. * Log in debug mode undone jira issues and chapters. * Log in debug mode comment added to Jira Release Status * Do branch checkout for non-release repos too-. * gitReleaseBranch id needs to be saved for future usage in pipeline. * If release manager branch is master, other comp. branch is defined in yaml. * Need to push to the branch we are looking for. * Initialize map before using it. * typo * Tests for InitStage * tests for MROPipelineUtil. * changelog * Reverts problematic change. Co-authored-by: Victor Pablos Ceruelo <victor.pablos_ceruelo.ext@boehringer-ingelheim.com> * Feature/edpc 1335 allow to redeploy in D, Q and P (#926) * Sets rePromote field to true by default + tests. * Check if tag exists. * Fixes tests readability. * Need to eval locally if tag exists before creating it. * changelog Co-authored-by: zxBCN Pablos_Ceruelo,Victor (IT EDS) EXTERNAL <victor.pablos_ceruelo.ext@boehringer-ingelheim.com> * changelog * Feature/edpc 1335 set repromote to true if unset (#927) * Sets rePromote field to true by default + tests. * Check if tag exists. * Fixes tests readability. * Need to eval locally if tag exists before creating it. * changelog Co-authored-by: zxBCN Pablos_Ceruelo,Victor (IT EDS) EXTERNAL <victor.pablos_ceruelo.ext@boehringer-ingelheim.com> Co-authored-by: Martinez,Angel (IT EDS) BI-ES-S <angel_2.martinez@boehringer-ingelheim.com> * Force push in RM tags with redeploy Co-authored-by: Victor Pablos Ceruelo <victor.pablos_ceruelo.ext@boehringer-ingelheim.com> Co-authored-by: Martinez,Angel (IT EDS) BI-ES-S <angel_2.martinez@boehringer-ingelheim.com> Co-authored-by: Jorge Romero <jorge.romeropalma@gmail.com> Co-authored-by: Rodriguez,Hector (IT EDS) <hector_2.rodriguez@boehringer-ingelheim.com>
3 tasks
victorpablosceruelo
added a commit
that referenced
this pull request
Aug 16, 2022
* Developer preview uses the release branch if exists, the branch in Release Manager's metadata.yml cfg if not. (#917) * changelog * Logging we need to see what is going on. * Small refactor to clarify what source code does. * Use release branch if it exists, in dev mode. * Checkout release branch for developer preview if available. Co-authored-by: Victor Pablos Ceruelo <victor.pablos_ceruelo.ext@boehringer-ingelheim.com> * Feature/edpc 1323 dev preview from release branch if exists (#920) * changelog * Logging we need to see what is going on. * Small refactor to clarify what source code does. * Use release branch if it exists, in dev mode. * Checkout release branch for developer preview if available. * Log in debug mode undone jira issues and chapters. * Log in debug mode comment added to Jira Release Status * Do branch checkout for non-release repos too-. * gitReleaseBranch id needs to be saved for future usage in pipeline. * If release manager branch is master, other comp. branch is defined in yaml. * Need to push to the branch we are looking for. * Initialize map before using it. * typo * Tests for InitStage * tests for MROPipelineUtil. * changelog Co-authored-by: Victor Pablos Ceruelo <victor.pablos_ceruelo.ext@boehringer-ingelheim.com> * Removes DIL_P doc. (#914) * Removes DIL_P doc. * Trying to log what is being sent to jira * Correct way to log variable. * Pretty print map using json format. * Revert "Correct way to log variable." This reverts commit 8ae309a. * Revert "Trying to log what is being sent to jira" This reverts commit 0367847. * jcenter is no more available. * Removes from test checking that DIL_P is generated. * changelog Co-authored-by: zxBCN Pablos_Ceruelo,Victor (IT EDS) EXTERNAL <victor.pablos_ceruelo.ext@boehringer-ingelheim.com> * Sets rePromote field to true by default + tests. * Check if tag exists. * Fixes tests readability. * Need to eval locally if tag exists before creating it. * edpc 1323 dev preview from release branch if exists (#925) * changelog * Logging we need to see what is going on. * Small refactor to clarify what source code does. * Use release branch if it exists, in dev mode. * Checkout release branch for developer preview if available. * Log in debug mode undone jira issues and chapters. * Log in debug mode comment added to Jira Release Status * Do branch checkout for non-release repos too-. * gitReleaseBranch id needs to be saved for future usage in pipeline. * If release manager branch is master, other comp. branch is defined in yaml. * Need to push to the branch we are looking for. * Initialize map before using it. * typo * Tests for InitStage * tests for MROPipelineUtil. * changelog * Reverts problematic change. Co-authored-by: Victor Pablos Ceruelo <victor.pablos_ceruelo.ext@boehringer-ingelheim.com> * Feature/edpc 1335 allow to redeploy in D, Q and P (#926) * Sets rePromote field to true by default + tests. * Check if tag exists. * Fixes tests readability. * Need to eval locally if tag exists before creating it. * changelog Co-authored-by: zxBCN Pablos_Ceruelo,Victor (IT EDS) EXTERNAL <victor.pablos_ceruelo.ext@boehringer-ingelheim.com> * changelog * Feature/edpc 1335 set repromote to true if unset (#927) * Sets rePromote field to true by default + tests. * Check if tag exists. * Fixes tests readability. * Need to eval locally if tag exists before creating it. * changelog Co-authored-by: zxBCN Pablos_Ceruelo,Victor (IT EDS) EXTERNAL <victor.pablos_ceruelo.ext@boehringer-ingelheim.com> Co-authored-by: Martinez,Angel (IT EDS) BI-ES-S <angel_2.martinez@boehringer-ingelheim.com> * Force push in RM tags with redeploy Co-authored-by: Victor Pablos Ceruelo <victor.pablos_ceruelo.ext@boehringer-ingelheim.com> Co-authored-by: Martinez,Angel (IT EDS) BI-ES-S <angel_2.martinez@boehringer-ingelheim.com> Co-authored-by: Jorge Romero <jorge.romeropalma@gmail.com> Co-authored-by: Rodriguez,Hector (IT EDS) <hector_2.rodriguez@boehringer-ingelheim.com> Co-authored-by: Victor Pablos Ceruelo <victor.pablos_ceruelo.ext@boehringer-ingelheim.com> Co-authored-by: Martinez,Angel (IT EDS) BI-ES-S <angel_2.martinez@boehringer-ingelheim.com> Co-authored-by: Jorge Romero <jorge.romeropalma@gmail.com> Co-authored-by: Rodriguez,Hector (IT EDS) <hector_2.rodriguez@boehringer-ingelheim.com>
victorpablosceruelo
added a commit
that referenced
this pull request
Aug 31, 2022
* Developer preview uses the release branch if exists, the branch in Release Manager's metadata.yml cfg if not. (#917) * changelog * Logging we need to see what is going on. * Small refactor to clarify what source code does. * Use release branch if it exists, in dev mode. * Checkout release branch for developer preview if available. Co-authored-by: Victor Pablos Ceruelo <victor.pablos_ceruelo.ext@boehringer-ingelheim.com> * Feature/edpc 1323 dev preview from release branch if exists (#920) * changelog * Logging we need to see what is going on. * Small refactor to clarify what source code does. * Use release branch if it exists, in dev mode. * Checkout release branch for developer preview if available. * Log in debug mode undone jira issues and chapters. * Log in debug mode comment added to Jira Release Status * Do branch checkout for non-release repos too-. * gitReleaseBranch id needs to be saved for future usage in pipeline. * If release manager branch is master, other comp. branch is defined in yaml. * Need to push to the branch we are looking for. * Initialize map before using it. * typo * Tests for InitStage * tests for MROPipelineUtil. * changelog Co-authored-by: Victor Pablos Ceruelo <victor.pablos_ceruelo.ext@boehringer-ingelheim.com> * Removes DIL_P doc. (#914) * Removes DIL_P doc. * Trying to log what is being sent to jira * Correct way to log variable. * Pretty print map using json format. * Revert "Correct way to log variable." This reverts commit 8ae309a. * Revert "Trying to log what is being sent to jira" This reverts commit 0367847. * jcenter is no more available. * Removes from test checking that DIL_P is generated. * changelog Co-authored-by: zxBCN Pablos_Ceruelo,Victor (IT EDS) EXTERNAL <victor.pablos_ceruelo.ext@boehringer-ingelheim.com> * Sets rePromote field to true by default + tests. * Check if tag exists. * Fixes tests readability. * Need to eval locally if tag exists before creating it. * edpc 1323 dev preview from release branch if exists (#925) * changelog * Logging we need to see what is going on. * Small refactor to clarify what source code does. * Use release branch if it exists, in dev mode. * Checkout release branch for developer preview if available. * Log in debug mode undone jira issues and chapters. * Log in debug mode comment added to Jira Release Status * Do branch checkout for non-release repos too-. * gitReleaseBranch id needs to be saved for future usage in pipeline. * If release manager branch is master, other comp. branch is defined in yaml. * Need to push to the branch we are looking for. * Initialize map before using it. * typo * Tests for InitStage * tests for MROPipelineUtil. * changelog * Reverts problematic change. Co-authored-by: Victor Pablos Ceruelo <victor.pablos_ceruelo.ext@boehringer-ingelheim.com> * Feature/edpc 1335 allow to redeploy in D, Q and P (#926) * Sets rePromote field to true by default + tests. * Check if tag exists. * Fixes tests readability. * Need to eval locally if tag exists before creating it. * changelog Co-authored-by: zxBCN Pablos_Ceruelo,Victor (IT EDS) EXTERNAL <victor.pablos_ceruelo.ext@boehringer-ingelheim.com> * changelog * Feature/edpc 1335 set repromote to true if unset (#927) * Sets rePromote field to true by default + tests. * Check if tag exists. * Fixes tests readability. * Need to eval locally if tag exists before creating it. * changelog Co-authored-by: zxBCN Pablos_Ceruelo,Victor (IT EDS) EXTERNAL <victor.pablos_ceruelo.ext@boehringer-ingelheim.com> Co-authored-by: Martinez,Angel (IT EDS) BI-ES-S <angel_2.martinez@boehringer-ingelheim.com> * Force push in RM tags with redeploy * Adds log to every single step where we can fail sending status to Jira. * Including more logs to see where the problem is. Co-authored-by: Victor Pablos Ceruelo <victor.pablos_ceruelo.ext@boehringer-ingelheim.com> Co-authored-by: Martinez,Angel (IT EDS) BI-ES-S <angel_2.martinez@boehringer-ingelheim.com> Co-authored-by: Jorge Romero <jorge.romeropalma@gmail.com> Co-authored-by: Rodriguez,Hector (IT EDS) <hector_2.rodriguez@boehringer-ingelheim.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DIL (Discrepance Log) is a document that should not be generated when going to Production ( DIL_P ).
This PR is to remove it.