Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable git lfs from ods-start #420

Closed
gerardcl opened this issue Jan 25, 2022 · 3 comments · Fixed by #422
Closed

Enable git lfs from ods-start #420

gerardcl opened this issue Jan 25, 2022 · 3 comments · Fixed by #422
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@gerardcl
Copy link
Member

We have detected that git LFS is not supported in ods-pipeline. Since it is a feature of current ODS we could try to add it here too.

Proposal would be to just replicate the installation from the jenkins-agent-base image to the ods-start image.

@gerardcl
Copy link
Member Author

gerardcl commented Jan 26, 2022

We have tested adding git LFS in a custom task with success.
The addition of this feature would be pretty simple like in ods-start just have a script check like (and of course first having git lfs installed in the ods-start image):

  # then check if there are lfs tracked files
  if [ `git lfs ls-files --all | wc -l` -gt 0 ]; then
    # if yes init and pull lfs
    echo "Git LFS detected, pulling files..."
    git lfs install # this enables the missing hooks to later be able to git lfs pull
    git lfs pull
  fi

And that to be added here:

FYI @michaelsauter @ManuelFeller

@gerardcl
Copy link
Member Author

I was now thinking that we might want to be added in the ods-start package so we can also provide tests, but, do we need to test this?

@michaelsauter
Copy link
Member

In general, everything should be in the ods-start package, see https://github.com/opendevstack/ods-pipeline/blob/master/docs/adr/20210511-executing-step-scripts.md.

@gerardcl gerardcl self-assigned this Jan 27, 2022
@gerardcl gerardcl added the enhancement New feature or request label Jan 27, 2022
@michaelsauter michaelsauter added this to the 0.3.0 milestone Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants