Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unformatted files in Go mod cache break the build #484

Closed
michaelsauter opened this issue Mar 28, 2022 · 0 comments · Fixed by #485
Closed

Unformatted files in Go mod cache break the build #484

michaelsauter opened this issue Mar 28, 2022 · 0 comments · Fixed by #485
Labels
bug Something isn't working

Comments

@michaelsauter
Copy link
Member

With the introduction of the persistent Go mod cache, unformatted files in that cache break the build now.

Since GOMODCACHE is set to $ROOT_DIR/.ods-cache/deps/gomod, files in the cache are considered when running gofmt -l .. This shouldn't be the case. Anything in the Go mod cache should be ignored.

I suggest to change to go fmt $(go list ./...).

FYI @henrjk
@michaelsauter michaelsauter added the bug Something isn't working label Mar 28, 2022
michaelsauter added a commit that referenced this issue Mar 28, 2022
@michaelsauter
Run go fmt over packages, not entire directory
c509b73 
Otherwise the now persistent Go mod cache is checked as well, and builds
will fail if any dependency is not gofmt'd.

Fixes #484.
@michaelsauter michaelsauter mentioned this issue Mar 28, 2022
Merged
4 tasks
michaelsauter added a commit that referenced this issue Mar 28, 2022
@michaelsauter
Run go fmt over packages, not entire directory
7438666 
Otherwise the now persistent Go mod cache is checked as well, and builds
will fail if any dependency is not gofmt'd.

Fixes #484.
michaelsauter added a commit that referenced this issue Mar 28, 2022
@michaelsauter
Run go fmt over packages, not entire directory
d79fcfc 
Otherwise the now persistent Go mod cache is checked as well, and builds
will fail if any dependency is not gofmt'd.

Fixes #484.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Run go fmt over packages, not entire directory opendevstack/ods-pipeline
1 participant
@michaelsauter