Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run lint script #533

Merged
merged 2 commits into from
May 31, 2022
Merged

Run lint script #533

merged 2 commits into from
May 31, 2022

Conversation

michaelsauter
Copy link
Member

@michaelsauter michaelsauter commented May 30, 2022 •
edited
Loading

Closes #532

Tasks:

  • Updated design documents in docs/design directory or not applicable
  • Updated user-facing documentation in docs directory or not applicable
  • Ran tests (e.g. make test) or not applicable
  • Updated changelog or not applicable

@michaelsauter michaelsauter self-assigned this May 30, 2022
@michaelsauter michaelsauter force-pushed the task/npm-lint branch 2 times, most recently from 77ffbee to 71e6557 Compare May 30, 2022 15:10
@michaelsauter michaelsauter marked this pull request as ready for review May 30, 2022 15:11
henninggross
henninggross reviewed May 31, 2022
View reviewed changes
Copy link
Member

@henninggross henninggross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, but other than those LGTM!

deploy/ods-pipeline/charts/tasks/templates/task-ods-build-npm.yaml Outdated Show resolved Hide resolved
docs/design/software-requirements-specification.adoc Outdated Show resolved Hide resolved
@michaelsauter
Copy link
Member Author

This has a great effect on test time, saving about 2 minutes. From 503s (see #524) down to 377s:

--- PASS: TestTaskODSBuildNPM (377.61s)
    --- PASS: TestTaskODSBuildNPM/fail_pulling_image_if_unsupported_node_version_is_specified (4.71s)
    --- PASS: TestTaskODSBuildNPM/build_backend_javascript_app (110.94s)
    --- PASS: TestTaskODSBuildNPM/build_javascript_app_with_custom_build_directory (56.44s)
    --- PASS: TestTaskODSBuildNPM/build_typescript_app_with_SQ_scan (120.88s)
    --- PASS: TestTaskODSBuildNPM/build_javascript_app_in_subdirectory_with_build_caching (58.26s)
    --- PASS: TestTaskODSBuildNPM/fail_linting_typescript_app_and_generate_lint_report (25.10s)

@michaelsauter michaelsauter merged commit 6c883c0 into master May 31, 2022
@michaelsauter michaelsauter deleted the task/npm-lint branch May 31, 2022 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cschweikert cschweikert cschweikert approved these changes

@henninggross henninggross henninggross approved these changes

@netzartist netzartist Awaiting requested review from netzartist

Assignees

@michaelsauter michaelsauter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run lint script instead of eslint directly
3 participants
@michaelsauter @cschweikert @henninggross