Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add simple manual test that can be used to clean up atlassian resources #250

Merged
merged 2 commits into from Dec 3, 2019

Conversation

stefanlack
Copy link
Contributor

closes #249

Copy link
Member

@rattermeyer rattermeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having something to clean up atlassian ressources is a good idea in development / test environments.
But having it here as a test is something I do not like. Smells somehow.
But currently, I have no simple idea to place it somewhere else.
Beside that it LGTM.
Perhaps someone else should also comment on this.

@stefanlack
Copy link
Contributor Author

stefanlack commented Oct 16, 2019

Alternatives:

  1. move from test-class to separate main class, But: does not change the fact, that user has to modify source code in order to clean up

  2. Move clean up implementation to service class, add new rest api for clean up functionality. That should be protected somehow, because potential damage can be very high if functionality is missused. Therefore, we have to introduce a new opendevstack role, e.g. opendevstack-superadministrators, only users in this role/group have rights to execute this functionality

  3. Add cleanup functionality to provisioning app gui. In this case, we need the opendevstack-superadministrators group as well.

Evaluation

    1. does not solve the issue, that one has to change code in order to cleanup bitbucket projects
    1. and 3. are much nicer, but introduce some work.

Consideration: do we reallys hould invest more effort, just for providing some functionality that is only used from a developer in some rare cases?

@stefanlack
Copy link
Contributor Author

@clemensutschig @michaelsauter @rattermeyer may you please give an opinion to this?

Copy link
Member

@rattermeyer rattermeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As no one else commented on this, we follow the proposed path

@stefanlack stefanlack merged commit 01c51eb into opendevstack:master Dec 3, 2019
@stefanlack stefanlack deleted the util-cleanup-atlassian branch December 3, 2019 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

provide a cleanup util for atlassian projects
2 participants