Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nyz): fix confusing shallow copy operation bug about next_obs #641

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

PaParaZz1
Copy link
Member

Description

fix confusing shallow copy operation bug about next_obs

Related Issue

#638

TODO

Check List

  • merge the latest version source branch/repo, and resolve all the conflicts
  • pass style check
  • pass all the tests

@PaParaZz1 PaParaZz1 added the bug Something isn't working label Apr 11, 2023
@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Merging #641 (ad6ab70) into main (1cb1038) will decrease coverage by 0.27%.
The diff coverage is 95.23%.

@@            Coverage Diff             @@
##             main     #641      +/-   ##
==========================================
- Coverage   82.64%   82.38%   -0.27%     
==========================================
  Files         578      579       +1     
  Lines       47266    46763     -503     
==========================================
- Hits        39063    38525     -538     
- Misses       8203     8238      +35     
Flag Coverage Δ
unittests 82.38% <95.23%> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...orker/collector/battle_episode_serial_collector.py 14.19% <0.00%> (ø)
...worker/collector/battle_sample_serial_collector.py 13.37% <0.00%> (ø)
ding/worker/collector/base_serial_collector.py 90.36% <100.00%> (+0.23%) ⬆️
ding/worker/collector/episode_serial_collector.py 96.17% <100.00%> (ø)
ding/worker/collector/sample_serial_collector.py 91.41% <100.00%> (ø)
...rker/collector/tests/test_base_serial_collector.py 100.00% <100.00%> (ø)

... and 223 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@PaParaZz1 PaParaZz1 merged commit 283ef35 into main Apr 11, 2023
@PaParaZz1 PaParaZz1 deleted the fix-to-transition branch April 11, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant