This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Support ES7.0, use primary_term and seq_no for job doc versioning #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zengyan-amazon
added
the
version compatibility
zengyan-amazon
requested review from
dbbaughe,
jinsoor-amzn,
lucaswin-amzn and
qreshi
dbbaughe
reviewed
May 15, 2019
| @@ -188,16 +188,16 @@ public void postIndex(ShardId shardId, Engine.Index index, Engine.IndexResult re | |||
|
|
|||
| ShardNodes shardNodes = new ShardNodes(localNodeId, shardNodeIds); | |||
| if (shardNodes.isOwningNode(index.id())) { | |||
| this.sweep(shardId, index.id(), result.getVersion(), index.source()); | |||
| this.sweep(shardId, index.id(), result.getVersion(), index.source(), result.getTerm(), result.getSeqNo()); | |||
There was a problem hiding this comment.
Can we pass in the JobDocVersion instead of all 3 properties separately to reduce parameters
There was a problem hiding this comment.
refactored to pass JobDocVersion
dbbaughe
reviewed
May 16, 2019
| @@ -218,7 +219,7 @@ void sweep(ShardId shardId, String docId, Long version, BytesReference jobSource | |||
| this.sweptJobs.put(shardId, jobVersionMap); | |||
| } | |||
| jobVersionMap.compute(docId, (id, currentVersion) -> { | |||
| JobDocVersion newJobVersion = new JobDocVersion(primaryTerm, seqNo, version); | |||
| JobDocVersion newJobVersion = new JobDocVersion(version.getPrimaryTerm(), version.getSeqNo(), version.getVersion()); | |||
There was a problem hiding this comment.
Why do you need to do this? Just use the given version from parameter for comparison?
There was a problem hiding this comment.
updated, fixed this silly code
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue #4 *
Description of changes: This change updates the JobScheduler plugin to build with Elasticsearch 7.0, and make the change to use document primary_term and seq_no for job versioning, which is a breaking change introduced in ES7.0.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.