Issue #142: Add a TODO to track the counter for overflow

opendnssec · May 31, 2017 · dff45d7 · dff45d7
1 parent b69183c
commit dff45d7
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/src/lib/SoftHSM.cpp b/src/lib/SoftHSM.cpp
@@ -2073,6 +2073,8 @@ CK_RV SoftHSM::SymEncryptInit(CK_SESSION_HANDLE hSession, CK_MECHANISM_PTR pMech
 				DEBUG_MSG("Invalid ulCounterBits");
 				return CKR_MECHANISM_PARAM_INVALID;
 			}
+			// TODO: Make sure that we do not cause an overflow of the counter
+			// block’s counter bits.
 
 			iv.resize(16);
 			memcpy(&iv[0], CK_AES_CTR_PARAMS_PTR(pMechanism->pParameter)->cb, 16);
@@ -2714,6 +2716,8 @@ CK_RV SoftHSM::SymDecryptInit(CK_SESSION_HANDLE hSession, CK_MECHANISM_PTR pMech
 				DEBUG_MSG("Invalid ulCounterBits");
 				return CKR_MECHANISM_PARAM_INVALID;
 			}
+			// TODO: Make sure that we do not cause an overflow of the counter
+			// block’s counter bits.
 
 			iv.resize(16);
 			memcpy(&iv[0], CK_AES_CTR_PARAMS_PTR(pMechanism->pParameter)->cb, 16);