-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #230: Install p11-kit module file #233
Conversation
Fixes #230 |
d8c6785
to
af28782
Compare
#build |
Getting this on our freebsd build machine. Will check it out.
|
In order for well-behaved applications to discover and use the PKCS#11 provider module, we should install a p11-kit module file for it. Allow this to be disabled by configuring with --disable-p11-kit, and do so in the Jenkins builds since they run as an unprivileged user and can't install to the standard p11-kit module directory.
Looks like the Jenkins builds are running unprivileged and installing to a location within the user's own home directory. So installation works fine, except for installing the p11-kit module file into the system directory. The simple answer is probably just to add In fact, perhaps real users installing their own might want it installed to the standard per-user |
#build |
Will merge this and send in a pull request that will fix build issue on FreeBSD |
Hm, I thought I'd already fixed the FreeBSD build issue in the latest update? Strictly speaking it wasn't a FreeBSD issue; it was an "installing as non-root" issue. So I addressed it by adding |
It was missing --disable-p11-kit on one row. |
In order for well-behaved applications to discover and use the PKCS#11
provider module, we should install a p11-kit module file for it.