Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #230: Install p11-kit module file #233

Merged
merged 1 commit into from
Sep 30, 2016
Merged

Issue #230: Install p11-kit module file #233

merged 1 commit into from
Sep 30, 2016

Conversation

dwmw2
Copy link
Contributor

@dwmw2 dwmw2 commented Sep 9, 2016

In order for well-behaved applications to discover and use the PKCS#11
provider module, we should install a p11-kit module file for it.

@dwmw2
Copy link
Contributor Author

dwmw2 commented Sep 9, 2016

Fixes #230

@dwmw2 dwmw2 force-pushed the develop branch 3 times, most recently from d8c6785 to af28782 Compare September 10, 2016 20:22
@bellgrim
Copy link
Contributor

#build

@bellgrim
Copy link
Contributor

Getting this on our freebsd build machine. Will check it out.

 /usr/local/bin/gmkdir -p '/usr/local/share/p11-kit/modules'
 /usr/bin/install -c -m 644 softhsm2.module '/usr/local/share/p11-kit/modules'
install: /usr/local/share/p11-kit/modules/softhsm2.module: Permission denied
Makefile:522: recipe for target 'install-p11modDATA' failed

Issue opendnssec#230: Install p11-kit module file
f1de8e2 
In order for well-behaved applications to discover and use the PKCS#11
provider module, we should install a p11-kit module file for it.

Allow this to be disabled by configuring with --disable-p11-kit, and do
so in the Jenkins builds since they run as an unprivileged user and
can't install to the standard p11-kit module directory.
@dwmw2
Copy link
Contributor Author

dwmw2 commented Sep 13, 2016 •
edited
Loading

Looks like the Jenkins builds are running unprivileged and installing to a location within the user's own home directory. So installation works fine, except for installing the p11-kit module file into the system directory. The simple answer is probably just to add --disable-p11-kit for that test build, since that's basically why we made it anoption. I've pushed that change.

In fact, perhaps real users installing their own might want it installed to the standard per-user ~/.config/pkcs11/modules/ location. But let's not worry about that for now.

@bellgrim
Copy link
Contributor

#build

@bellgrim
Copy link
Contributor

Will merge this and send in a pull request that will fix build issue on FreeBSD

@bellgrim bellgrim merged commit a0804df into opendnssec:develop Sep 30, 2016
@dwmw2
Copy link
Contributor Author

dwmw2 commented Sep 30, 2016

Hm, I thought I'd already fixed the FreeBSD build issue in the latest update? Strictly speaking it wasn't a FreeBSD issue; it was an "installing as non-root" issue. So I addressed it by adding --disable-p11-kit to the test invocations in testing/build-softhsm2.sh

@bellgrim
Copy link
Contributor

It was missing --disable-p11-kit on one row.

This was referenced Sep 30, 2016
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dwmw2 @bellgrim