improve odg #160
Merged
improve odg #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomTasche
approved these changes
Apr 18, 2020
| const auto x2 = in.FindAttribute("svg:x2"); | ||
| const auto y2 = in.FindAttribute("svg:y2"); | ||
|
|
||
| if ((x1 == nullptr) || (y1 == nullptr) || (x2 == nullptr) || (y2 == nullptr)) |
There was a problem hiding this comment.
sometimes you're using braces for one-liner ifs, sometimes you don't. see https://github.com/opendocument-app/OpenDocument.core/pull/160/files?diff=unified&w=1#diff-1c9779dd88891fa701d5a9d97b8a3c59R68-R70
There was a problem hiding this comment.
i actually don't want braces for one-liners. it is quite hard to find them.
| @@ -104,6 +125,7 @@ void StyleClassTranslator(const tinyxml2::XMLElement &in, std::ostream &out, | |||
| out << "}\n"; | |||
| } | |||
|
|
|||
| // TODO | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
besides improving odg this also contains
<br>