Depcheck issues #30
Depcheck issues #30
Conversation
gradle.properties
Outdated
| @@ -1 +1 @@ | |||
| version=2.5.0-SNAPSHOT | |||
There was a problem hiding this comment.
gradle.properties is updated by the one who deploy the release. Please undo this.
build.gradle
Outdated
| testImplementation('org.apache.kafka:kafka_2.12:2.3.1') { | ||
| exclude group: 'org.scala-lang', module: 'scala-reflect' | ||
| } | ||
| testImplementation group: 'org.scala-lang', name: 'scala-reflect', version: '2.12.11' |
There was a problem hiding this comment.
latest release is 2.13.2 . Why 2.12.11 ?
There was a problem hiding this comment.
Because new version needs another version of kafka.
The other way is to change kafka, or get a compilation error.
There was a problem hiding this comment.
Got this compilation error with version 2.13.2: /src/test/java/com/opendxl/databus/util/Topic.java:65: error: cannot access Serializable
new TopicCommand.ZookeeperTopicService(zkUtils).createTopic(opts);
^
class file for scala.Serializable not found
There was a problem hiding this comment.
So last compatible version is 2.12.11 released on march 2020.
https://mvnrepository.com/artifact/org.scala-lang/scala-reflect
There was a problem hiding this comment.
Discussed and finally will be use 2.12.11
| } | ||
| implementation ('org.apache.kafka:kafka-streams:2.3.1') { | ||
| exclude group: 'org.scala-lang', module: 'scala-reflect' | ||
| } | ||
| implementation 'org.apache.avro:avro:1.9.0' |
There was a problem hiding this comment.
Should you add a entry for scala-reflect in implementation ?
build.gradle
Outdated
| kafkaInMemory ('org.apache.kafka:kafka_2.12:2.3.1') { | ||
| exclude group: 'org.scala-lang', module: 'scala-reflect' | ||
| } | ||
| kafkaInMemory group: 'org.scala-lang', name: 'scala-reflect', version: '2.12.11' |
There was a problem hiding this comment.
Discussed and finally will be use 2.12.11
We are fixing this Vulnerability:
scala-reflect-2.12.8.jar (pkg:maven/org.scala-lang/scala-reflect@2.12.8, cpe:2.3:a:scala-lang:scala:2.12.8:::::::*) : CWE-79: Improper Neutralization of Input During Web Page Generation ('Cross-site Scripting')