chore(provision): cleannup the volume at the provisioning time #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pawan <pawan@mayadata.io>
Closed
iyashu
reviewed
Aug 25, 2021
iyashu
reviewed
Aug 25, 2021
| err = removeVolumeFilesystem(vol) | ||
| if err != nil { | ||
| klog.Infof("lvm: volume %s filesystem cleanup failed", volume) | ||
| } |
There was a problem hiding this comment.
Shall we propagate the error if wipefs fails by returning err?
There was a problem hiding this comment.
as create volume already succeded and cleaning the filesystem is not the hard error, so ignoring the error here.
There was a problem hiding this comment.
may be it is better to propagate the error. added the code to handle that.
Signed-off-by: Pawan <pawan@mayadata.io>
|
closing this PR as we already clean the filesystem while creating the volume (#88). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes : #135
Cleanup the volume while provisioing it. If disk already had some partitions before and volume landed at the same offset where the old volume was present with the filesystem, we should clean it at the creation time. We already do the same at the deletion time.