feat(lvm-localpv): make the installation of snapshot.storage.k8s.io CRDs optional #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is infact impact me with argocd could this get merged with a small release |
|
Closing this PR. This commit has been included in PR #243. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this PR required? What issue does it fix?:
change for #203
What this PR does?:
This PR will enable the possibility to disable the installation of the volumesnapshot CRDs.
To prevent any regressions, the default has been set to true.
These resources are usually maintained and managed by the underlying kubernetes distribution. In case of OpenShift, it will automatically revert back the modifications made by this helmchart. This could be problematic if you use ArgoCD and have it on autosync.
Checklist:
<type>(<scope>): <subject>