Add describe pool command #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vharsh
reviewed
May 25, 2021
vharsh
reviewed
May 25, 2021
vharsh
reviewed
May 25, 2021
| } | ||
|
|
||
| for _, bd := range BdInfo { | ||
| err = util.PrintByTemplate("bd", blockDevicesInfoFromCSPI, bd) |
There was a problem hiding this comment.
PrintByTemplatemay not be a good UI/UX as in case of multiple BDs the above will generate something like this:-
Block Device Details :
----------------
Name : blockdevice-c21bc3b79a98c7e8508f47558cc94f36
Capacity : 107374182400
State : Active
Block Device Details :
----------------
Name : blockdevice-c21bc3b79a98c7e8508f47558cc94f36
Capacity : 107374182400
State : Active
The above should have been like this, similar to kubectl get list.
Block Device Details :
----------------
Name Capacity State
bd-1 107641 active
bd-2 187261 active
You can refer this code for the same:-
| } | ||
|
|
||
| for _, cvr := range CVRInfoInPool { | ||
| err = util.PrintByTemplate("cvr", provisionedReplicasInfoFromCSPI, cvr) |
There was a problem hiding this comment.
PrintByTemplatemay not be a good UI/UX as in case of multiple CVRs the above will generate something like this:-
Provisioned Replicas Details :
----------------
Name : pvc-b84f60ae-3f26-4110-a85d-bce7ec00dacc-default-cstor-disk-dcrm
PVC Name : mongo
Size : 1.04G
Status : Healthy
Provisioned Replicas Details :
----------------
Name : pvc-b84f60ae-3f26-4110-a85d-bce7ec00dacc-default-cstor-disk-dcrm
PVC Name : mongo
Size : 1.04G
Status : Healthy
The above should have been like this, similar to kubectl get list.
Provisioned Replicas Details :
----------------
Name PvcName Size Status
cvr-1 pvc-1 107641 Healthy
cvr-2 pvc-2 187261 Degraded
You can refer this code for the same:-
| ---------------- | ||
| Name : {{.Name}} | ||
| Capacity : {{.Capacity}} | ||
| State : {{.State}} |
There was a problem hiding this comment.
- Indentation is a bit off here.
You can ignore this comment if the above comments are addressed.
| poolInfoCommandHelpText = ` | ||
| This command fetches information and status of the various aspects | ||
| of the cStor Pool Instance and its underlying related resources in the provided namespace. | ||
| If no namespace is provided it uses default namespace for execution. |
There was a problem hiding this comment.
- Please change the line to
If no namespace is provided it uses openebs namespace for execution.
| This command fetches information and status of the various aspects | ||
| of the cStor Pool Instance and its underlying related resources in the provided namespace. | ||
| If no namespace is provided it uses default namespace for execution. | ||
| $ kubectl openebs describe pool [cspi-name] -n [namespace] |
There was a problem hiding this comment.
Please change the namespace word to openebs ns
$ kubectl openebs describe pool [cspi-name] -n [openebs ns]
|
@ParthS007 Please send in a new PR to ACK these review comments. |
|
Line no. 297 in k8s.go has repeated 'while' text. Please rectify the same. |
Line no. 306 as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #15