(feat) Add lvm volumegroup describe feature #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 12, 2021 22:45
Signed-off-by: Harsh Vardhan <harsh.vardhan@mayadata.io>
Signed-off-by: Harsh Vardhan <harsh.vardhan@mayadata.io>
6 tasks
vharsh
commented
Aug 12, 2021
| {Cells: []interface{}{"pool-1", "node1", "174 GiB", "188 GiB", false, int32(2), int32(2), "ONLINE"}}, | ||
| {Cells: []interface{}{"pool-2", "node2", "174 GiB", "188 GiB", false, int32(2), int32(2), "ONLINE"}}}, | ||
| {Cells: []interface{}{"pool-1", "node1", "174.0GiB", "188.1GiB", false, int32(2), int32(2), "ONLINE"}}, | ||
| {Cells: []interface{}{"pool-2", "node2", "174.0GiB", "188.1GiB", false, int32(2), int32(2), "ONLINE"}}}, |
There was a problem hiding this comment.
I've made these changes to make sure that the unit-tests are all green, I'll revert nonsense updates like changing of 174.0GiB back to 174GiB after making sure no unit-tests fail in the entire project.
vharsh
commented
Aug 12, 2021
vharsh
commented
Aug 12, 2021
| if err != nil { | ||
| return value | ||
| } | ||
| return units.BytesSize(float64(iBytes)) | ||
| return units.CustomSize("%.1f%s", float64(bytes), 1024.0, []string{"B", "KiB", "MiB", "GiB", "TiB", "PiB", "EiB", "ZiB", "YiB"}) |
There was a problem hiding this comment.
Need to find a better format specifier such that 1024 bytes show up as 1KiB and not 1.0KiB.
There was a problem hiding this comment.
Maybe upto 2 decimal place is a better precision.
Abhinandan-Purkait
approved these changes
Aug 13, 2021
| if err != nil { | ||
| return value | ||
| } | ||
| return units.BytesSize(float64(iBytes)) | ||
| return units.CustomSize("%.1f%s", float64(bytes), 1024.0, []string{"B", "KiB", "MiB", "GiB", "TiB", "PiB", "EiB", "ZiB", "YiB"}) |
There was a problem hiding this comment.
Maybe upto 2 decimal place is a better precision.
I'll do it in upcoming PRs, this would need some digging around format specifiers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Harsh Vardhan harsh.vardhan@mayadata.io