Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(version): use the travis tag for the version #114

Merged
merged 1 commit into from
May 14, 2020

Conversation

pawanpraka1
Copy link
Contributor

@pawanpraka1 pawanpraka1 commented May 14, 2020

if there are no changes then "git describe --tags git rev-list --tags --max-count=1"
may return older tag as there will be two tags referring to the same commit.

Using travis tag here to clearly differentiate the versions.

Signed-off-by: Pawan pawan@mayadata.io

@pawanpraka1 pawanpraka1 added the enhancement Add new functionality to existing feature label May 14, 2020
@pawanpraka1 pawanpraka1 added this to the v0.7.0 milestone May 14, 2020
@pawanpraka1 pawanpraka1 requested a review from kmova May 14, 2020 10:22
if there are no changes then `git describe --tags `git rev-list --tags --max-count=1`
may return older tag as there will be two tags referring to the same commit.

Using travis tag here to clearly differentiate the versions.

Signed-off-by: Pawan <pawan@mayadata.io>
@codecov-io
Copy link

Codecov Report

Merging #114 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #114   +/-   ##
=======================================
  Coverage   22.90%   22.90%           
=======================================
  Files          14       14           
  Lines         489      489           
=======================================
  Hits          112      112           
  Misses        376      376           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c81ba9...8b454bb. Read the comment docs.

@kmova kmova added this to RC2 - Due May 10, 2020 in 1.10 Release Tracker - Due May 15th. May 14, 2020
@kmova kmova added this to In Review in ZFS Local PV May 14, 2020
@kmova kmova merged commit 4a92213 into openebs:master May 14, 2020
ZFS Local PV automation moved this from In Review to Done May 14, 2020
1.10 Release Tracker - Due May 15th. automation moved this from RC2 - Due May 10, 2020 to Done May 14, 2020
@pawanpraka1 pawanpraka1 modified the milestones: v0.8.0, v0.7.0 May 14, 2020
@pawanpraka1 pawanpraka1 deleted the version branch May 14, 2020 13:12
pawanpraka1 pushed a commit that referenced this pull request Jul 2, 2021
Signed-off-by: Josh Cox <josh@webhosting.coop>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Add new functionality to existing feature
Projects
ZFS Local PV
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants